Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decimal digit token filter docs #7923 #7977

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Add decimal digit token filter docs #7923 #7977

merged 8 commits into from
Nov 5, 2024

Conversation

AntonEliatra
Copy link
Contributor

Description

Add decimal digit token filter docs

Issues Resolved

Partly closes #7923

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@AntonEliatra
Copy link
Contributor Author

I added -- around the number range (0-9) to fix vale errors, but don't know if it looks ok now

@kolchfa-aws
Copy link
Collaborator

@AntonEliatra The range should be 0--9. I updated it

@kolchfa-aws
Copy link
Collaborator

@udabhas Could you review this PR for technical accuracy?

@kolchfa-aws kolchfa-aws added 3 - Tech review PR: Tech review in progress analyzers labels Aug 15, 2024
@kolchfa-aws kolchfa-aws assigned vagimeli and unassigned kolchfa-aws Aug 15, 2024
@vagimeli
Copy link
Contributor

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

@vagimeli vagimeli added the Needs SME Waiting on input from subject matter expert label Aug 29, 2024
@AntonEliatra
Update decimal-digit.md
aa2c3a9 
Signed-off-by: AntonEliatra <[email protected]>
@vagimeli
Copy link
Contributor

vagimeli commented Oct 3, 2024

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

@varun-lodaya This is over a month old. We need tech review approval to move it forward in the documentation process. Please review this week or provide a peer who can review it. Thank you.

udabhas
udabhas approved these changes Oct 19, 2024
View reviewed changes
Copy link

@udabhas udabhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

kolchfa-aws
kolchfa-aws approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra! A couple of small changes.

_analyzers/token-filters/decimal-digit.md Outdated Show resolved Hide resolved
_analyzers/token-filters/decimal-digit.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws self-assigned this Oct 31, 2024
@AntonEliatra @kolchfa-aws
Apply suggestions from code review
01f55e1 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
natebower
natebower reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra @kolchfa-aws Just one minor change. Thanks!

_analyzers/token-filters/decimal-digit.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws merged commit 76b7bca into opensearch-project:main Nov 5, 2024
5 checks passed
@kolchfa-aws kolchfa-aws added the backport 2.17 Backport for version 2.17 label Nov 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 5, 2024
@github-actions @kolchfa-aws @natebower
Add decimal digit token filter docs #7923 (#7977)
c94fc09 
* Adding decimal digit token filter docs #7923

Signed-off-by: Anton Rubin <[email protected]>

* Adding -- around the number range

Signed-off-by: Anton Rubin <[email protected]>

* Update _analyzers/token-filters/decimal-digit.md

Signed-off-by: kolchfa-aws <[email protected]>

* Update decimal-digit.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update _analyzers/token-filters/decimal-digit.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 76b7bca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@opensearch-trigger-bot
Add decimal digit token filter docs #7923 (#7977) (#8657)
01d52af
@AntonEliatra AntonEliatra deleted the adding-decimal-digit-token-filter-docs branch November 7, 2024 12:33
epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
@AntonEliatra @kolchfa-aws
@natebower @epugh
Add decimal digit token filter docs opensearch-project#7923 (opensear…
e934bc2 
…ch-project#7977)

* Adding decimal digit token filter docs opensearch-project#7923

Signed-off-by: Anton Rubin <[email protected]>

* Adding -- around the number range

Signed-off-by: Anton Rubin <[email protected]>

* Update _analyzers/token-filters/decimal-digit.md

Signed-off-by: kolchfa-aws <[email protected]>

* Update decimal-digit.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update _analyzers/token-filters/decimal-digit.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@udabhas udabhas udabhas approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

Assignees

@kolchfa-aws kolchfa-aws

Labels
3 - Tech review PR: Tech review in progress analyzers backport 2.17 Backport for version 2.17 Needs SME Waiting on input from subject matter expert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Token filter pages for common_grams, conditional and decimal_digit[DOC]
5 participants
@AntonEliatra @kolchfa-aws @vagimeli @udabhas @natebower