Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in Operations reference #7975

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Fix links in Operations reference #7975

merged 4 commits into from
Aug 13, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

epugh
epugh previously requested changes Aug 12, 2024
Copy link
Collaborator

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale burped on one formatting with //. Does vale prevent the /api-reference/index-apis/ style link?

@Naarcha-AWS
Copy link
Collaborator Author

Vale burped on one formatting with //. Does vale prevent the /api-reference/index-apis/ style link?

It does since double slashes break the link. Fixed.

@Naarcha-AWS Naarcha-AWS requested a review from epugh August 12, 2024 21:46
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS LGTM with a few changes. Thanks!

_benchmark/reference/workloads/operations.md Outdated Show resolved Hide resolved
_benchmark/reference/workloads/operations.md Outdated Show resolved Hide resolved
_benchmark/reference/workloads/operations.md Outdated Show resolved Hide resolved
Naarcha-AWS and others added 2 commits August 13, 2024 08:49
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS dismissed epugh’s stale review August 13, 2024 13:50

Review feedback addressed

@Naarcha-AWS Naarcha-AWS merged commit 1e6d6fa into main Aug 13, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 13, 2024
* Fix links in Operations reference

Signed-off-by: Archer <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update _benchmark/reference/workloads/operations.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Archer <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 1e6d6fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS deleted the operations-links branch December 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants