-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new results landing page for website search #7942
Add new results landing page for website search #7942
Conversation
Signed-off-by: Zelin Hao <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
cdcb90a
to
52d59d3
Compare
cc @smacrakis |
Hi @zelinh A few observations:
Thanks. |
A few more nitpik for this:
|
Thank you, @zelinh! In terms of UI, I would change the following:
Functionality nice-to-haves:
|
Signed-off-by: Zelin Hao <[email protected]>
Updated the PR to accommodate the suggestions:
@peterzhuamazon @kolchfa-aws Please help take a look here. Thanks. |
Signed-off-by: Zelin Hao <[email protected]>
5a8057b
to
85f3713
Compare
Looks better now. Still miss radiobutton. |
I think a checkbox group works better because radio buttons mean exclusive OR. Checkboxes imply regular OR (users can check one or more checkboxes). |
@zelinh Thanks for updating! A couple of things:
Thanks! |
Signed-off-by: Zelin Hao <[email protected]>
Updated with new commits. Please help review again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, @zelinh!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zelinh !
* Add new results landing page for website Signed-off-by: Zelin Hao <[email protected]> * Update some features Signed-off-by: Zelin Hao <[email protected]> * Update the margin between search results Signed-off-by: Zelin Hao <[email protected]> * Update display when no checkbox selected Signed-off-by: Zelin Hao <[email protected]> --------- Signed-off-by: Zelin Hao <[email protected]> (cherry picked from commit 9b8c68d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website Signed-off-by: Zelin Hao <[email protected]> * Update some features Signed-off-by: Zelin Hao <[email protected]> * Update the margin between search results Signed-off-by: Zelin Hao <[email protected]> * Update display when no checkbox selected Signed-off-by: Zelin Hao <[email protected]> --------- Signed-off-by: Zelin Hao <[email protected]> (cherry picked from commit 9b8c68d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new results landing page for website * Update some features * Update the margin between search results * Update display when no checkbox selected --------- (cherry picked from commit 9b8c68d) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add new results landing page for website search for documentation website.
This will be a separate search results page besides than the current dropdown menu.
The page will have options to do advanced search such as version selector and documentation-only search.
The backend API support is pending and will be onboarded pretty soon.
Issues Resolved
Part of these community request. opensearch-project/project-website-search#43 (comment)
Part of opensearch-project/project-website-search#65
Version
All versions will be backported.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.