Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #7921

Merged
merged 119 commits into from
Aug 7, 2024
Merged

Fix typo #7921

merged 119 commits into from
Aug 7, 2024

Conversation

epugh
Copy link
Collaborator

@epugh epugh commented Aug 6, 2024

Description

Fix a typo

Issues Resolved

na

Version

2.15

Frontend features

Checklist

  • [x ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

RasonJ and others added 30 commits June 13, 2024 11:13
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>
hdhalter and others added 11 commits July 2, 2024 16:44
There were some hidden comments that I found in this file.

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Removed links on 'object_id' and 'query_id'

Signed-off-by: Heather Halter <[email protected]>
removed a note tag and fixed line 326

Signed-off-by: Heather Halter <[email protected]>
One more table heading

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Copy link

github-actions bot commented Aug 6, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

Hey @epugh Could you please rebase to remove extraneous commits? Thanks!

@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress backport 2.15 labels Aug 7, 2024
@Naarcha-AWS Naarcha-AWS merged commit ca1c9d9 into opensearch-project:main Aug 7, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 7, 2024
* gathering potential documentation attempts

Signed-off-by: RasonJ <[email protected]>

* considering the dashboard tutorial

Signed-off-by: RasonJ <[email protected]>

* place holder for js data structure usage

Signed-off-by: RasonJ <[email protected]>

* data-structures placeholder

Signed-off-by: RasonJ <[email protected]>

* Updating index links

Signed-off-by: RasonJ <[email protected]>

* adding old doc to be merged

Signed-off-by: RasonJ <[email protected]>

* Starting to link things together

Signed-off-by: RasonJ <[email protected]>

* fix broken link

Signed-off-by: RasonJ <[email protected]>

* respond to vale

Signed-off-by: RasonJ <[email protected]>

* more vale violations

Signed-off-by: RasonJ <[email protected]>

* name files consistently with docs site and fix links.

Signed-off-by: RasonJ <[email protected]>

* vale

Signed-off-by: RasonJ <[email protected]>

* Minor tweaks.  Moved Ubi under SEARCH.

Signed-off-by: RasonJ <[email protected]>

* add label for versining of spec and OS version

Signed-off-by: RasonJ <[email protected]>

* try to sort out vale error

Signed-off-by: RasonJ <[email protected]>

* Converting mermaid diagrams to png's

Signed-off-by: RasonJ <[email protected]>

* Updating query_id mermaid code

Signed-off-by: RasonJ <[email protected]>

* Better way to ignore the mermaid scripts in the md files

Signed-off-by: RasonJ <[email protected]>

* description updates

Signed-off-by: RasonJ <[email protected]>

* schema.md updating (still need to update the mermaid diagram)

Signed-off-by: RasonJ <[email protected]>

* schema updates

Signed-off-by: RasonJ <[email protected]>

* updates

Signed-off-by: RasonJ <[email protected]>

* Rebuilding main

Signed-off-by: RasonJ <[email protected]>

* merging in images

Signed-off-by: RasonJ <[email protected]>

* Updating UBI spec number

Signed-off-by: RasonJ <[email protected]>

* Use released version

Signed-off-by: Eric Pugh <[email protected]>

* Update _search-plugins/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Addressing PR feedback

Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/data-structures.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/data-structures.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/data-structures.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/data-structures.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Adding dsl intro

Signed-off-by: RasonJ <[email protected]>

* Adding intro sentence

Signed-off-by: RasonJ <[email protected]>

* Title adjust

Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Addressing PR feedback

Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Addressing pr feedback

Signed-off-by: RasonJ <[email protected]>

* Addressing PR feedback

Signed-off-by: RasonJ <[email protected]>

* Fixing vale errors

Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Finishing initial pr feedback

Signed-off-by: RasonJ <[email protected]>

* Next round of PR feedback

Signed-off-by: RasonJ <[email protected]>

* Describing chorus workbench link

Signed-off-by: RasonJ <[email protected]>

* Adding captions for result tables

Signed-off-by: RasonJ <[email protected]>

* PR clean up

Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Adding a few more suggestions

Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* updating query filter for laptos

Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* PR feedback

Signed-off-by: RasonJ <[email protected]>

* Update _search-plugins/ubi/ubi-dashboard-tutorial.md

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* PR feedback

Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: RasonJ <[email protected]>

* Apply suggestions from code review

Edits to all files to comply with OpenSearch standards; nav_order updates

Signed-off-by: Heather Halter <[email protected]>

* Apply suggestions from code review

Missed a file - more commits to the sql-query topic

Signed-off-by: Heather Halter <[email protected]>

* Update _search-plugins/ubi/sql-queries.md

Signed-off-by: Heather Halter <[email protected]>

* Apply suggestions from code review

Cleaned up the sample query topic

Signed-off-by: Heather Halter <[email protected]>

* Apply suggestions from code review

Signed-off-by: Heather Halter <[email protected]>

* Update _search-plugins/ubi/dsl-queries.md

Signed-off-by: Heather Halter <[email protected]>

* Update _search-plugins/ubi/dsl-queries.md

Signed-off-by: Heather Halter <[email protected]>

* Apply suggestions from code review

Accepted editorial suggestions.

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update index.md

Reformatted table info

Signed-off-by: Heather Halter <[email protected]>

* Update _search-plugins/ubi/dsl-queries.md

Signed-off-by: Heather Halter <[email protected]>

* Apply suggestions from code review

Signed-off-by: Heather Halter <[email protected]>

* Update index.md

Signed-off-by: Heather Halter <[email protected]>

* Update schemas.md

Signed-off-by: Heather Halter <[email protected]>

* Update index.md

Added a missing link and fixed the table.

Signed-off-by: Heather Halter <[email protected]>

* Update index.md

Changed the bold to italics

Signed-off-by: Heather Halter <[email protected]>

* Update ubi-dashboard-tutorial.md

Removed unnecessary note tag.

Signed-off-by: Heather Halter <[email protected]>

* Update schemas.md

Inserted comma

Signed-off-by: Heather Halter <[email protected]>

* Update sql-queries.md

Signed-off-by: Heather Halter <[email protected]>

* Apply suggestions from code review

There were some hidden comments that I found in this file.

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _search-plugins/ubi/sql-queries.md

Signed-off-by: Heather Halter <[email protected]>

* Update _search-plugins/ubi/sql-queries.md

Signed-off-by: Heather Halter <[email protected]>

* Apply suggestions from code review

Signed-off-by: Heather Halter <[email protected]>

* Update _search-plugins/ubi/schemas.md

Signed-off-by: kolchfa-aws <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

* Update schemas.md

Removed links on 'object_id' and 'query_id'

Signed-off-by: Heather Halter <[email protected]>

* Update sql-queries.md

removed a note tag and fixed line 326

Signed-off-by: Heather Halter <[email protected]>

* Update sql-queries.md

One more table heading

Signed-off-by: Heather Halter <[email protected]>

* found a typo

Signed-off-by: Eric Pugh <[email protected]>

---------

Signed-off-by: RasonJ <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: RasonJ <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit ca1c9d9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants