Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing search results new page added to documentation #7919

Merged

Conversation

leanneeliatra
Copy link
Contributor

Description

New page added to documentation to address the functionality of Collapsing Search Results in OpenSearch

Issues Resolved

Part of #7507

Version

all

Frontend features

n/a

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Aug 6, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@hdhalter hdhalter added the 3 - Tech review PR: Tech review in progress label Aug 6, 2024
@hdhalter hdhalter added backport 2.15 search-and-query Issue: Issues related to search and query features labels Aug 6, 2024
@leanneeliatra
Copy link
Contributor Author

leanneeliatra commented Aug 7, 2024

Hi @hdhalter, @Naarcha-AWS this is ready for review please.

@Naarcha-AWS
Copy link
Collaborator

@rishabhmaurya: Could you take a look at this one?

@hdhalter hdhalter removed their assignment Aug 7, 2024
vagimeli and others added 10 commits September 12, 2024 14:25
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@leanneeliatra
Copy link
Contributor Author

Review comments addressed. cc @vagimeli

@natebower natebower added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 5 - Editorial review PR: Editorial review in progress labels Sep 17, 2024
@vagimeli vagimeli added backport 2.17 Backport for version 2.17 and removed 6 - Done but waiting to merge PR: The work is done and ready to merge backport 2.16 labels Sep 24, 2024
@vagimeli vagimeli merged commit 1cbacf9 into opensearch-project:main Sep 24, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
* adding documentation for collapsing search results

Signed-off-by: [email protected] <[email protected]>

* Clarifying collapsing of search results

Signed-off-by: [email protected] <[email protected]>

* updating collapsing example as per request

Signed-off-by: [email protected] <[email protected]>

* updates as per reviewdog

Signed-off-by: [email protected] <[email protected]>

* updates as per review dog

Signed-off-by: [email protected] <[email protected]>

* remove unneeded space

Signed-off-by: [email protected] <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Review suggestions addressed

Signed-off-by: [email protected] <[email protected]>

* update to language

Signed-off-by: [email protected] <[email protected]>

* update to language from review

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 1cbacf9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra added a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this pull request Oct 17, 2024
…-project#7919)

* adding documentation for collapsing search results

Signed-off-by: [email protected] <[email protected]>

* Clarifying collapsing of search results

Signed-off-by: [email protected] <[email protected]>

* updating collapsing example as per request

Signed-off-by: [email protected] <[email protected]>

* updates as per reviewdog

Signed-off-by: [email protected] <[email protected]>

* updates as per review dog

Signed-off-by: [email protected] <[email protected]>

* remove unneeded space

Signed-off-by: [email protected] <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _search-plugins/collapse-search.md

Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Review suggestions addressed

Signed-off-by: [email protected] <[email protected]>

* update to language

Signed-off-by: [email protected] <[email protected]>

* update to language from review

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.17 Backport for version 2.17 search-and-query Issue: Issues related to search and query features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants