Add documentation for ingest-attachment plugin #7891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldrick
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@cwperks - Can you tech review this one? |
Taking a look |
cwperks
reviewed
Aug 6, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 6, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 6, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
|
@hdhalter The technical content of the document looks good to me. |
hdhalter
added
4 - Doc review
Signed-off-by: Ricky Lippmann <[email protected]>
Signed-off-by: Ricky Lippmann <[email protected]>
* Added target_bulk_bytes Signed-off-by: Sander van de Geijn <[email protected]> * Update _tools/logstash/ship-to-opensearch.md Nice Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]> * Update _tools/logstash/ship-to-opensearch.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Update ship-to-opensearch.md * Remove "we" * Update ship-to-opensearch.md * Update ship-to-opensearch.md * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Sander van de Geijn <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
* Add doc for binary format support in k-NN Signed-off-by: Junqiu Lei <[email protected]> * Resolve tech feedback Signed-off-by: Junqiu Lei <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Add newline Signed-off-by: Fanit Kolchina <[email protected]> * Formatting Signed-off-by: Fanit Kolchina <[email protected]> * Link fix Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Add query results to examples Signed-off-by: Junqiu Lei <[email protected]> * Rephrased sentences and changed vector field name Signed-off-by: Fanit Kolchina <[email protected]> * Editorial review Signed-off-by: Fanit Kolchina <[email protected]> * Remove details from one of the requests Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
* Edit for redundant information and sections across Data Prepper Signed-off-by: Melissa Vagi <[email protected]> * Edit for redundant information and sections across Data Prepper Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/index.md Signed-off-by: Melissa Vagi <[email protected]> * Update configuring-data-prepper.md Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/pipelines.md Signed-off-by: Melissa Vagi <[email protected]> * Update expression-syntax.md Signed-off-by: Melissa Vagi <[email protected]> * Create Functions subpages Signed-off-by: Melissa Vagi <[email protected]> * Create functions subpages Signed-off-by: Melissa Vagi <[email protected]> * Copy edit Signed-off-by: Melissa Vagi <[email protected]> * add remaining subpages Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/index.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Apply suggestions from code review Accepted editorial suggestions. Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Apply suggestions from code review Accepted more editorial suggestions that were hidden. Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: David Venable <[email protected]> * removed-line Signed-off-by: Heather Halter <[email protected]> * Fixed broken link to pipelines Signed-off-by: Heather Halter <[email protected]> * Fixed broken links on Update add-entries.md Signed-off-by: Heather Halter <[email protected]> * Fixed broken link in Update dynamo-db.md Signed-off-by: Heather Halter <[email protected]> * Fixed link syntax in Update index.md Signed-off-by: Heather Halter <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Heather Halter <[email protected]> Signed-off-by: David Venable <[email protected]> Signed-off-by: Heather Halter <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Co-authored-by: David Venable <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
fixed typo Signed-off-by: Philipp Dünnebeil <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
* Refactor k-NN documentation Signed-off-by: Fanit Kolchina <[email protected]> * Change field name for cohesiveness Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
* add batch inference API Signed-off-by: Xun Zhang <[email protected]> * add more links and mark the api as experimental Signed-off-by: Xun Zhang <[email protected]> * use openAI as the blueprint example details Signed-off-by: Xun Zhang <[email protected]> * address comments Signed-off-by: Xun Zhang <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
* adding apostrophe token filter page #7871 Signed-off-by: AntonEliatra <[email protected]> * fixing vale error Signed-off-by: AntonEliatra <[email protected]> * Update apostrophe-token-filter.md Signed-off-by: AntonEliatra <[email protected]> * updating the naming Signed-off-by: AntonEliatra <[email protected]> * updating as per the review comments Signed-off-by: AntonEliatra <[email protected]> * updating the heading to Apostrophe token filter Signed-off-by: AntonEliatra <[email protected]> * updating as per PR comments Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]>
Signed-off-by: Ricky Lippmann <[email protected]>
Signed-off-by: Ricky Lippmann <[email protected]>
Signed-off-by: Ricky Lippmann <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
reviewed
Aug 6, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
|
@ldrick: I added some edits on top of your PR. Could you take another look and make sure none of my edits changed the technical meaning of the documentation? |
Thank you very much, I already looked yesterday through 19a5838 and tried to get how to improve my english in documentations. I've brought back small missing parts and tried to keep your better wording 👍 |
Naarcha-AWS
approved these changes
Aug 7, 2024
natebower
requested changes
Aug 7, 2024
There was a problem hiding this comment.
@ldrick @Naarcha-AWS Please see my comments and changes and tag me for approval when addressed. Thanks!
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Aug 7, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Aug 7, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Aug 7, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Aug 7, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
reviewed
Aug 7, 2024
_install-and-configure/additional-plugins/ingest-attachment-plugin.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
natebower
approved these changes
Aug 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
* add ingest-attachment plugin doc Signed-off-by: Ricky Lippmann <[email protected]> * extend ingest-attachment with information how to limit content Signed-off-by: Ricky Lippmann <[email protected]> * Added target_bulk_bytes to the docs for logstash-output plugin (#7869) * Added target_bulk_bytes Signed-off-by: Sander van de Geijn <[email protected]> * Update _tools/logstash/ship-to-opensearch.md Nice Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]> * Update _tools/logstash/ship-to-opensearch.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Update ship-to-opensearch.md * Remove "we" * Update ship-to-opensearch.md * Update ship-to-opensearch.md * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Sander van de Geijn <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Add doc for binary format support in k-NN (#7840) * Add doc for binary format support in k-NN Signed-off-by: Junqiu Lei <[email protected]> * Resolve tech feedback Signed-off-by: Junqiu Lei <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Add newline Signed-off-by: Fanit Kolchina <[email protected]> * Formatting Signed-off-by: Fanit Kolchina <[email protected]> * Link fix Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Add query results to examples Signed-off-by: Junqiu Lei <[email protected]> * Rephrased sentences and changed vector field name Signed-off-by: Fanit Kolchina <[email protected]> * Editorial review Signed-off-by: Fanit Kolchina <[email protected]> * Remove details from one of the requests Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Edit for redundant information and sections across Data Prepper (#7127) * Edit for redundant information and sections across Data Prepper Signed-off-by: Melissa Vagi <[email protected]> * Edit for redundant information and sections across Data Prepper Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Rewrite expression syntax and reorganize doc structure for readability Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/index.md Signed-off-by: Melissa Vagi <[email protected]> * Update configuring-data-prepper.md Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/pipelines.md Signed-off-by: Melissa Vagi <[email protected]> * Update expression-syntax.md Signed-off-by: Melissa Vagi <[email protected]> * Create Functions subpages Signed-off-by: Melissa Vagi <[email protected]> * Create functions subpages Signed-off-by: Melissa Vagi <[email protected]> * Copy edit Signed-off-by: Melissa Vagi <[email protected]> * add remaining subpages Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/index.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Apply suggestions from code review Accepted editorial suggestions. Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Apply suggestions from code review Accepted more editorial suggestions that were hidden. Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: David Venable <[email protected]> * removed-line Signed-off-by: Heather Halter <[email protected]> * Fixed broken link to pipelines Signed-off-by: Heather Halter <[email protected]> * Fixed broken links on Update add-entries.md Signed-off-by: Heather Halter <[email protected]> * Fixed broken link in Update dynamo-db.md Signed-off-by: Heather Halter <[email protected]> * Fixed link syntax in Update index.md Signed-off-by: Heather Halter <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Heather Halter <[email protected]> Signed-off-by: David Venable <[email protected]> Signed-off-by: Heather Halter <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Co-authored-by: David Venable <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Update index.md (#7893) fixed typo Signed-off-by: Philipp Dünnebeil <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Fix typo and make left nav heading uniform for neural sparse processor (#7895) Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Add custom JSON lexer and highlighting color scheme (#7892) * Add custom JSON lexer and highlighting color scheme Signed-off-by: Fanit Kolchina <[email protected]> * Update _getting-started/quickstart.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Add model names to Vale (#7901) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Renamed data prepper files to have dashes for consistency (#7790) * Renamed data prepper files to have dashes for consistency Signed-off-by: Fanit Kolchina <[email protected]> * More files Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Add documentation for ml inference search request processor/ search response processor (#7852) * draft ml inference search request processor Signed-off-by: Mingshi Liu <[email protected]> * add doc Signed-off-by: Mingshi Liu <[email protected]> * add doc Signed-off-by: Mingshi Liu <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Fixed links Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Unify processor docs Signed-off-by: Fanit Kolchina <[email protected]> * Update _query-dsl/geo-and-xy/xy.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Remove note Signed-off-by: Fanit Kolchina <[email protected]> * Fix link Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Refactor k-NN documentation (#7890) * Refactor k-NN documentation Signed-off-by: Fanit Kolchina <[email protected]> * Change field name for cohesiveness Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Ml commons batch inference (#7899) * add batch inference API Signed-off-by: Xun Zhang <[email protected]> * add more links and mark the api as experimental Signed-off-by: Xun Zhang <[email protected]> * use openAI as the blueprint example details Signed-off-by: Xun Zhang <[email protected]> * address comments Signed-off-by: Xun Zhang <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Remove repeated sentence in distributed tracing doc (#7906) Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * Add apostrophe token filter page #7871 (#7884) * adding apostrophe token filter page #7871 Signed-off-by: AntonEliatra <[email protected]> * fixing vale error Signed-off-by: AntonEliatra <[email protected]> * Update apostrophe-token-filter.md Signed-off-by: AntonEliatra <[email protected]> * updating the naming Signed-off-by: AntonEliatra <[email protected]> * updating as per the review comments Signed-off-by: AntonEliatra <[email protected]> * updating the heading to Apostrophe token filter Signed-off-by: AntonEliatra <[email protected]> * updating as per PR comments Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Ricky Lippmann <[email protected]> * removed unnecessary backslash Signed-off-by: Ricky Lippmann <[email protected]> * fix:add missing whitespace in table Signed-off-by: Ricky Lippmann <[email protected]> * docs: add link to tika supported file formats Signed-off-by: Ricky Lippmann <[email protected]> * Update ingest-attachment-plugin.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * adjust to keep technical specific information with improved wording Signed-off-by: Ricky Lippmann <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Ricky Lippmann <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Heather Halter <[email protected]> Signed-off-by: David Venable <[email protected]> Signed-off-by: Heather Halter <[email protected]> Signed-off-by: Philipp Dünnebeil <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Xun Zhang <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: AntonEliatra <[email protected]> Co-authored-by: Sander van de Geijn <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Co-authored-by: Junqiu Lei <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: David Venable <[email protected]> Co-authored-by: Philipp Dünnebeil <[email protected]> Co-authored-by: Mingshi Liu <[email protected]> Co-authored-by: Xun Zhang <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: AntonEliatra <[email protected]> (cherry picked from commit 8b731c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added documentation for
ingest-attachmentpluginIssues Resolved
Closes 7858
Version
2.15
Frontend features
Just documentation
Inspiration
I had to describe some of the things taking https://www.elastic.co/guide/en/elasticsearch/reference/current/attachment.html as inspiration, as the
ingest-attachmentplugin is close to their plugin. If that is not allowed, please help me to rewrite necessary parts.Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.