Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Documentation for dynamic query parameters for kNN search request #7761
Adds Documentation for dynamic query parameters for kNN search request #7761
Changes from 5 commits
b782565
5b2157a
a4d87d2
6519ef3
835259d
b9b8db6
f8b82db
58d5697
d3d1020
5dc7bbf
00e9280
501bb5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 256 in _search-plugins/knn/approximate-knn.md
GitHub Actions / style-job
Check failure on line 291 in _search-plugins/knn/approximate-knn.md
GitHub Actions / style-job
Check failure on line 291 in _search-plugins/knn/approximate-knn.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain this more? Is this saying that users can either specify
k
oref_search
but not both? How issize
affecting the final number of results? Please clarify the last sentence.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, Users have to specify
k
. There are validations which will fails otherwise. On engine level, we cannot pass k and ef_search both. If ef_search is present in method parameters it picks the max of both.Now as a side effect there will be more results per shard if ef_search value is higher than k. So user will have to use
size
to get the final results. Thinking more about it we can remove the size sentence, since even right now the final results are controlled bysize
if k > sizeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! I think it's helpful to provide the last sentence. Made a suggestion to include this info.