Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent to Aggregation topics #7715

Closed
wants to merge 1 commit into from
Closed

Add parent to Aggregation topics #7715

wants to merge 1 commit into from

Conversation

hdhalter
Copy link
Contributor

Description

Trying to fix the breadcrumb problem

Issues Resolved

Closes #6935

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Heather Halter <[email protected]>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@hdhalter hdhalter changed the title addparent Add parent to Aggregation topics Jul 16, 2024
@hdhalter
Copy link
Contributor Author

@AMoo-Miki, @Naarcha-AWS , @kolchfa-aws - I added a parent topic to the subtopics, but with this fix, they don't appear in the nav pane (see #6935 (comment)). You can navigate to them, you just can't see them. Any ideas on how to get this to work correctly? If it can't work with our current config, we can close this PR.

@hdhalter hdhalter added the 2 - In progress Issue/PR: The issue or PR is in progress. label Jul 16, 2024
@kolchfa-aws
Copy link
Collaborator

The index pages for the collections have to be excluded from the parent/grandparent relationship. Let me put a fix through: you can close this PR.

@kolchfa-aws
Copy link
Collaborator

Fixed in #7758

@Naarcha-AWS Naarcha-AWS deleted the fix-aggregations branch December 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In progress Issue/PR: The issue or PR is in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Hierarchical breadcrumb links to the wrong place
2 participants