Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Prepper documentation updates: autogeneration campaign #7707
Data Prepper documentation updates: autogeneration campaign #7707
Changes from 3 commits
92253c0
207d783
5270f9a
b7be720
83b762d
a303b27
13ca7ca
b42adf7
10ce5cd
53e6bf3
dbfb348
5d57e40
8e3a1ae
eb2b16b
73cb9ce
dcb06b4
c6a791e
fc90c15
4d55b4c
9c56721
fc9cd7e
1914ed6
f56783c
81e354f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlvenable @chenqi0805 Is this saying that scale is only modified when the option is converted to
big_decimal
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a new commit that attempts to correct the wording.
We are modifying the scale of the
big_decimal
value itself. This field is only applicable forbig_decimal
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlvenable @chenqi0805 The description for delete_source is the same as line 30. Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a mistake on my part. I just pushed a new change that should correct this.