Add PR checklist workflow #7699
Conversation
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
requested review from
hdhalter,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you mark the PR ready for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly, or leave comments and editorial suggestions for you to approve, make changes, and commit yourself (let us know in a comment if you have a preference.) The doc reviewer will arrange for an editorial review. |
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you mark the PR ready for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly, or leave comments and editorial suggestions for you to approve, make changes, and commit yourself (let us know in a comment if you have a preference.) The doc reviewer will arrange for an editorial review. |
Signed-off-by: Fanit Kolchina <[email protected]>
There was a problem hiding this comment.
@kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| issue-number: ${{ github.event.pull_request.number }} | ||
| body: | | ||
| Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. |
There was a problem hiding this comment.
Should these match the GitHub labels? In other words, how will these states be apparent to the author?
There was a problem hiding this comment.
Some of them do (like "In progress", "Doc review", and "Tech review"). "Editorial review" label is "Final editorial review" but I'd rather change the label if needed because the goal here is to provide some hints with minimum number of words.
There was a problem hiding this comment.
Some of them do (like "In progress", "Doc review", and "Tech review"). "Editorial review" label is "Final editorial review" but I'd rather change the label if needed because the goal here is to provide some hints with minimum number of words.
Agreed - I changed the label.
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Fanit Kolchina <[email protected]>
* Add PR checklist workflow Signed-off-by: Fanit Kolchina <[email protected]> * Assign to user instead of owner Signed-off-by: Fanit Kolchina <[email protected]> * Testing Signed-off-by: Fanit Kolchina <[email protected]> * Remove test Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * If a PR is submitted by a doc team member, assign that member Signed-off-by: Fanit Kolchina <[email protected]> * Remove test Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: [email protected] <[email protected]>
* Add PR checklist workflow Signed-off-by: Fanit Kolchina <[email protected]> * Assign to user instead of owner Signed-off-by: Fanit Kolchina <[email protected]> * Testing Signed-off-by: Fanit Kolchina <[email protected]> * Remove test Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * If a PR is submitted by a doc team member, assign that member Signed-off-by: Fanit Kolchina <[email protected]> * Remove test Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]>
Adds a workflow that will comment with the doc repo process and assign all incoming PRs to the repo owner for triage.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.