Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.15] Add some example results to make functionality clearer #7687

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[Backport 2.15] Add some example results to make functionality clearer #7687

merged 1 commit into from
Jul 11, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 33ba41c from #7686.

@github-actions
Add some example results to make functionality clearer (#7686)
9c4c77e 
There doesn't seem to be a detailed spec for these functions.
For example, what are the arguments of substring? First and last positions? (no) First position and length? (yes) Is position 0-origin or 1-origin? (1-origin) Does it accept counting position from the end with negative arguments? (yes)

I've added an example result which at least clarifies the first 3 questions.

Signed-off-by: Stavros Macrakis <[email protected]>
(cherry picked from commit 33ba41c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the backport-automerge Added by backport workflow for automerge label Jul 11, 2024
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from epugh as a code owner July 11, 2024 17:42
@github-actions github-actions bot merged commit 2ff98fc into 2.15 Jul 11, 2024
6 checks passed
@github-actions github-actions bot deleted the backport/backport-7686-to-2.15 branch July 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees
No one assigned
Labels
backport-automerge Added by backport workflow for automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants