Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Recovery API #7653

Merged
merged 14 commits into from
Jul 24, 2024
Merged

Add Recovery API #7653

merged 14 commits into from
Jul 24, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Closes #2098

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS Naarcha-AWS self-assigned this Jul 9, 2024
@Naarcha-AWS Naarcha-AWS added 2 - In progress Issue/PR: The issue or PR is in progress. API labels Jul 9, 2024
@Naarcha-AWS
Add examples
182746c 
Signed-off-by: Archer <[email protected]>
@Naarcha-AWS
Fix link and parameter
2a0fd4d 
Signed-off-by: Archer <[email protected]>
@Naarcha-AWS Naarcha-AWS marked this pull request as ready for review July 9, 2024 15:22
@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Jul 9, 2024
@Naarcha-AWS
Copy link
Collaborator Author

@gaobinlong: Could you help me with a technical review of this API PR?

gaobinlong
gaobinlong reviewed Jul 19, 2024
View reviewed changes
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
@Naarcha-AWS @gaobinlong
Apply suggestions from code review
bbd3de7 
Co-authored-by: gaobinlong <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS
Copy link
Collaborator Author

@gaobinlong: Addressed your feedback.

@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jul 23, 2024
@Naarcha-AWS
Update recover.md
3c4fab8 
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS changed the title Add Recover Index API Add Recovery API Jul 23, 2024
hdhalter
hdhalter suggested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nate! I have a few suggestions.

_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
hdhalter
hdhalter reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated my suggestion on capitalization, since the standard is to capitalize the API name.

_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
Naarcha-AWS and others added 4 commits July 23, 2024 16:47
@Naarcha-AWS @hdhalter
Apply suggestions from code review
af9f9c1 
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@hdhalter
Update _api-reference/index-apis/recover.md
89ddf1b 
Signed-off-by: Heather Halter <[email protected]>
@hdhalter
Update _api-reference/index-apis/recover.md
d5dbb2a 
Signed-off-by: Heather Halter <[email protected]>
@Naarcha-AWS
Update recover.md
1e597f5 
Signed-off-by: Naarcha-AWS <[email protected]>
hdhalter
hdhalter approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Jul 23, 2024
natebower
natebower requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Please see my requested changes and let me know if you have any questions. Thanks!

_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
_api-reference/index-apis/recover.md Outdated Show resolved Hide resolved
Naarcha-AWS and others added 2 commits July 24, 2024 10:41
@Naarcha-AWS @natebower
Apply suggestions from code review
fef3b56 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/index-apis/recover.md
dd37ddf 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
natebower
natebower approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Naarcha-AWS Naarcha-AWS merged commit 5a788e9 into main Jul 24, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@github-actions @gaobinlong
@hdhalter @natebower
Add Recovery API (#7653)
2b23d08 
* Add Recover Index API

Signed-off-by: Archer <[email protected]>

* Add examples

Signed-off-by: Archer <[email protected]>

* Fix link and parameter

Signed-off-by: Archer <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: gaobinlong <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update recover.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update _api-reference/index-apis/recover.md

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/recover.md

Signed-off-by: Heather Halter <[email protected]>

* Update recover.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update _api-reference/index-apis/recover.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Archer <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 5a788e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot
Add Recovery API (#7653) (#7824)
e8d96cc
sandervandegeijn pushed a commit to sandervandegeijn/documentation-website that referenced this pull request Jul 30, 2024
@Naarcha-AWS @gaobinlong
@hdhalter @natebower @sandervandegeijn
Add Recovery API (opensearch-project#7653)
d7e0afc 
* Add Recover Index API

Signed-off-by: Archer <[email protected]>

* Add examples

Signed-off-by: Archer <[email protected]>

* Fix link and parameter

Signed-off-by: Archer <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: gaobinlong <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update recover.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update _api-reference/index-apis/recover.md

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/recover.md

Signed-off-by: Heather Halter <[email protected]>

* Update recover.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update _api-reference/index-apis/recover.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Archer <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Sander van de Geijn <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the recovery-api branch December 19, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaobinlong gaobinlong gaobinlong left review comments

@hdhalter hdhalter hdhalter approved these changes

@natebower natebower natebower approved these changes

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@Naarcha-AWS Naarcha-AWS

Labels
5 - Editorial review PR: Editorial review in progress API backport 2.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]Create documentation for _recovery API
4 participants
@Naarcha-AWS @gaobinlong @natebower @hdhalter