Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incorrect ignore_malformed query parameter. #7652

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 9, 2024

Description

The documentation for put_mapping seems to imply that ignore_malformed can be specified as a query parameter. It's a valid index field mapping parameter but doesn't look like it can be specified on the query string. It's also not in the API spec.

$ curl -k -u admin:$OPENSEARCH_PASSWORD -X PUT https://localhost:9200/movies | jq
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "index": "movies"
}

$ curl -k -u admin:$OPENSEARCH_PASSWORD -X PUT https://localhost:9200/movies/_mapping?ignore_unavailable=true --json "{}" | jq
{
  "acknowledged": true
}

$ curl -k -u admin:$OPENSEARCH_PASSWORD -X PUT https://localhost:9200/movies/_mapping?ignore_malformed=true --json "{}" | jq
{
  "error": {
    "root_cause": [
      {
        "type": "illegal_argument_exception",
        "reason": "request [/movies/_mapping] contains unrecognized parameter: [ignore_malformed] -> did you mean [ignore_throttled]?"
      }
    ],
    "type": "illegal_argument_exception",
    "reason": "request [/movies/_mapping] contains unrecognized parameter: [ignore_malformed] -> did you mean [ignore_throttled]?"
  },
  "status": 400
}

The ignore_throttled parameter mentioned here looks deprecated, so we don't document it, which I think is right/separate problem.

Version

2.x

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS Naarcha-AWS merged commit 46fecd2 into opensearch-project:main Jul 9, 2024
6 checks passed
@Naarcha-AWS Naarcha-AWS added backport 2.15 backport 1.3 PR: Backport label for v1.3.x labels Jul 9, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: dblock <[email protected]>
(cherry picked from commit 46fecd2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: dblock <[email protected]>
(cherry picked from commit 46fecd2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra pushed a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this pull request Jul 24, 2024
sandervandegeijn pushed a commit to sandervandegeijn/documentation-website that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants