Remove model requirement from hybrid search documentation #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
requested review from
hdhalter,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
@navneet1v Could you review this PR please? |
navneet1v
reviewed
Jun 26, 2024
_search-plugins/hybrid-search.md
Outdated
| @@ -12,7 +12,7 @@ Introduced 2.11 | |||
| Hybrid search combines keyword and neural search to improve search relevance. To implement hybrid search, you need to set up a [search pipeline]({{site.url}}{{site.baseurl}}/search-plugins/search-pipelines/index/) that runs at search time. The search pipeline you'll configure intercepts search results at an intermediate stage and applies the [`normalization_processor`]({{site.url}}{{site.baseurl}}/search-plugins/search-pipelines/normalization-processor/) to them. The `normalization_processor` normalizes and combines the document scores from multiple query clauses, rescoring the documents according to the chosen normalization and combination techniques. | |||
|
|
|||
| **PREREQUISITE**<br> | |||
| Before using hybrid search, you must set up a text embedding model. For more information, see [Choosing a model]({{site.url}}{{site.baseurl}}/ml-commons-plugin/integrating-ml-models/#choosing-a-model). | |||
| To follow this example, you must set up a text embedding model. For more information, see [Choosing a model]({{site.url}}{{site.baseurl}}/ml-commons-plugin/integrating-ml-models/#choosing-a-model). | |||
There was a problem hiding this comment.
can we mention that having a embedding model is not required if you already have the embeddings for the text
There was a problem hiding this comment.
In this case, they can just directly set up hybrid search, correct? I added that sentence.
There was a problem hiding this comment.
no actually thats not the case. What we need to tell them is if you already have the embeddings directly ingest the embeddings and skip the ingest pipeline creation step.
There was a problem hiding this comment.
Sure. I revised the sentence.
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
approved these changes
Jul 15, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Remove model requirement from hybrid search documentation Signed-off-by: Fanit Kolchina <[email protected]> * Review comment Signed-off-by: Fanit Kolchina <[email protected]> * Revised sentence Signed-off-by: Fanit Kolchina <[email protected]> * Update _search-plugins/hybrid-search.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 72713ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
…-project#7511) * Remove model requirement from hybrid search documentation Signed-off-by: Fanit Kolchina <[email protected]> * Review comment Signed-off-by: Fanit Kolchina <[email protected]> * Revised sentence Signed-off-by: Fanit Kolchina <[email protected]> * Update _search-plugins/hybrid-search.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: [email protected] <[email protected]>
sandervandegeijn
pushed a commit
to sandervandegeijn/documentation-website
that referenced
this pull request
Jul 30, 2024
…-project#7511) * Remove model requirement from hybrid search documentation Signed-off-by: Fanit Kolchina <[email protected]> * Review comment Signed-off-by: Fanit Kolchina <[email protected]> * Revised sentence Signed-off-by: Fanit Kolchina <[email protected]> * Update _search-plugins/hybrid-search.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7401
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.