Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update key value processor documentation with new config options #7413

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Update key value processor documentation with new config options #7413

merged 9 commits into from
Jun 24, 2024

Conversation

kkondaka
Copy link
Contributor

Description

Update key value processor documentation with the following new config options.
strict_grouping
string_literal_character
key_value_when

Issues Resolved

Version

all.

Checklist

  • [ X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

vagimeli
vagimeli approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review complete with some rewrites for clarity. Moving to editorial. I'll address any editorial comments and then merge the PR. Thank you.

@vagimeli vagimeli assigned vagimeli and unassigned vagimeli Jun 20, 2024
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress data-prepper labels Jun 20, 2024
natebower
natebower reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli @kkondaka Please see my changes and let me know if you have any questions. Thanks!

_data-prepper/pipelines/configuration/processors/key-value.md Outdated Show resolved Hide resolved
_data-prepper/pipelines/configuration/processors/key-value.md Outdated Show resolved Hide resolved
@vagimeli vagimeli removed the 5 - Editorial review PR: Editorial review in progress label Jun 21, 2024
@vagimeli vagimeli merged commit 38cf9c6 into opensearch-project:main Jun 24, 2024
5 checks passed
@vagimeli vagimeli added the backport 2.14 PR: Backport label for 2.14 label Jun 24, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 24, 2024
@github-actions @vagimeli @natebower
Update key value processor documentation with new config options (#7413)
d49dd72 
* Update key value processor documentation with new config options

Signed-off-by: Kondaka <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Kondaka <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 38cf9c6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 24, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
@opensearch-trigger-bot
Update key value processor documentation with new config options (#7413…
de951f7 
…) (#7452)
leanneeliatra pushed a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this pull request Jul 24, 2024
@kkondaka @vagimeli
@natebower @leanneeliatra
Update key value processor documentation with new config options (ope…
e1ffa94 
…nsearch-project#7413)

* Update key value processor documentation with new config options

Signed-off-by: Kondaka <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/pipelines/configuration/processors/key-value.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Kondaka <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@vagimeli vagimeli vagimeli approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@vagimeli vagimeli

Labels
backport 2.14 PR: Backport label for 2.14 data-prepper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkondaka @natebower @vagimeli