-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting-envars-docs #3582 #7400
Merged
Naarcha-AWS
merged 4 commits into
opensearch-project:main
from
AntonEliatra:setting-envars
Jul 9, 2024
Merged
Setting-envars-docs #3582 #7400
Naarcha-AWS
merged 4 commits into
opensearch-project:main
from
AntonEliatra:setting-envars
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AntonEliatra <[email protected]>
AntonEliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
June 17, 2024 14:46
Signed-off-by: AntonEliatra <[email protected]>
stephen-crawford
approved these changes
Jun 24, 2024
hdhalter
added
4 - Doc review
PR: Doc review in progress
and removed
3 - Tech review
PR: Tech review in progress
labels
Jun 24, 2024
Naarcha-AWS
requested changes
Jul 3, 2024
Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Naarcha-AWS
approved these changes
Jul 5, 2024
Naarcha-AWS
added
5 - Editorial review
PR: Editorial review in progress
and removed
4 - Doc review
PR: Doc review in progress
labels
Jul 5, 2024
natebower
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS @AntonEliatra A few comments for you. Thanks!
Signed-off-by: AntonEliatra <[email protected]>
@natebower good catch, thats updated now |
natebower
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
* setting-envars-docs #3582 Signed-off-by: AntonEliatra <[email protected]> * Update index.md Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Update index.md Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 8f6ea3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 tasks
hdhalter
added
3 - Done
Issue is done/complete
and removed
5 - Editorial review
PR: Editorial review in progress
labels
Jul 10, 2024
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
* setting-envars-docs opensearch-project#3582 Signed-off-by: AntonEliatra <[email protected]> * Update index.md Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Update index.md Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: [email protected] <[email protected]>
sandervandegeijn
pushed a commit
to sandervandegeijn/documentation-website
that referenced
this pull request
Jul 30, 2024
* setting-envars-docs opensearch-project#3582 Signed-off-by: AntonEliatra <[email protected]> * Update index.md Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Update index.md Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expanding on options to configure envars in OpenSearch
Issues Resolved
Partly closes #3582
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.