Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multiple data sources and add TSVB and Vega viz types #7229
Update multiple data sources and add TSVB and Vega viz types #7229
Changes from 19 commits
3444cd3
da5a66b
e24f0d4
4d95088
dbeb1fc
6045594
0579355
6c5d0fc
d2cf069
4d461fd
1f62857
956c07b
9886080
9de6631
6db6392
45a51ca
55dbcbf
ef450d0
1569b9d
1cd6f7a
183de14
69dd8a0
64da49f
5edcceb
a3b8fd6
334e54d
c39f92d
a96c92e
dd185c5
b8f6a75
c2acdee
87ad874
d7be094
4a7d9ae
0429a41
20f0bb0
81ff0fe
b4e52ef
6813cd0
49aee03
6e16e10
fe6e4a6
8b5bee4
d4327af
dab6b7b
1836276
c18233d
4811ef4
6d84850
de5e9f3
eb98b31
582b89a
98ae5dd
dc11e05
442ef62
c52dc36
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connect "to" data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this list actually made more sense with the "Learn about" construct. As written, these are now not totally consistent, and it's not clear that the list items are all resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With regard to the question in the resolved comment: Yes, it should be "self-hosted".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step doesn't appear to be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should 'timestamp' be in bold if they enter it as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huyaboo Please provide examples of the information that the user enters in the Fields and Row template fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huyaboo What type of information does the user enter in the Fields and Row template fields. Please provide examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli The user will enter in document fields. For this example, they enter in the word "timestamp" for both
Fields
andRow template
since "timestamp" is a field in the document