-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rename ingest processor supports overriding target field if exists #6988
Conversation
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Doc review complete. Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc review complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaobinlong @vagimeli Just one comment. Thanks!
@@ -34,6 +34,7 @@ The following table lists the required and optional parameters for the `rename` | |||
`field` | Required | The field name containing the data to be removed. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets). | | |||
`target_field` | Required | The new name of the field. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets). | | |||
`ignore_missing` | Optional | Specifies whether the processor should ignore documents that do not contain the specified `field`. If set to `true`, the processor does not modify the document if the `field` does not exist. Default is `false`. | | |||
`override_target` | Optional | Determines the behavior when `target_field` already exists in the document. If set to `true`, the processor overwrites the existing `target_field` value with the new value. Default is `false`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we clarify the type of behavior ("X behavior") or use something like "method used"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised to read: Determines what happens when target_field
exists in the document. If set to true
, the processor overwrites the existing target_field
value with the new value. If set to false
, the existing value remains and the processor does not overwrite it. Default is false
.
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Description
In 2.14.0, we'll add a new parameter override_target for the existing rename ingest processor, we need to add the parameter in the documentation of the rename ingest processor.
Issues Resolved
Closes #6949
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.