New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding proxy configuration #20231107 #20230503 in 4314 issue #6952

Merged

hdhalter merged 12 commits into opensearch-project:main from AntonEliatra:proxy-config

May 16, 2024

Contributor

AntonEliatra commented Apr 15, 2024

Description

Adding details on proxy configuration for cross cluster search and basic details for proxy configuration itself using Nginx

Issues Resolved

#20231107 - /docs/latest/security/authentication-backends/proxy/ | Even though everything is set, I am still facing 401 error
#20230503 - /docs/latest/security/access-control/cross-cluster-search/ |What about other details? What if my port is proxied?

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.


          adding proxy configuration #20231107 #20230503 in 4314 issue

559ba87

Signed-off-by: AntonEliatra <[email protected]>

AntonEliatra requested review from hdhalter, kolchfa-aws, Naarcha-AWS, vagimeli, AMoo-Miki, natebower, dlvenable, stephen-crawford and epugh as code owners

April 15, 2024 10:53

AntonEliatra added 2 commits

April 15, 2024 11:57


          adding proxy configuration #20231107 #20230503 in 4314 issue

2cf06b6

Signed-off-by: AntonEliatra <[email protected]>


          Update cross-cluster-search.md

9a5d4cf

Signed-off-by: AntonEliatra <[email protected]>

AntonEliatra mentioned this pull request

[DOC] Feedback on Security topics #4314

Closed

20 tasks

hdhalter added security 4 - Doc review backport 2.13 3 - Tech review and removed 4 - Doc review labels

hdhalter assigned stephen-crawford

stephen-crawford approved these changes

View reviewed changes

Contributor

stephen-crawford left a comment

This looks reasonable, but I don't know anything about cross cluster search of the proxy configuration being discussed so let's just make sure we are extra confident in what is shared.

Contributor Author

AntonEliatra commented Apr 23, 2024

Thanks @scrawfor99 I tested this fully, using 2 separate clusters prior to raising the PR, therefore can confirm this does indeed works as described

Contributor

hdhalter commented Apr 23, 2024

Thanks, @scrawfor99. Let's have someone from the cluster team take a look. I'll ping @rohiwali.

Contributor

hdhalter commented Apr 23, 2024 •

edited

Loading

Hi @natebower , when we come across a proper noun that is getting flagged by Vale, do we always add it to our approved list or handle some other way? This is the name getting flagged: https://www.nginx.com/. Thanks!

Update: I just checked our style guide and this is already included as an accepted term, just capitalized.

hdhalter reviewed

View reviewed changes

Contributor

hdhalter left a comment

Thanks, @AntonEliatra . Here are some wording suggestions and fixes to the Vale errors.

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

d63bfb7

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

ankitkala reviewed

View reviewed changes

Member

ankitkala left a comment

Few minor comments. Rest LGTM!

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

AntonEliatra added 2 commits

April 24, 2024 17:45


          adding prerequisite to cross-cluster page

da81f4f

Signed-off-by: AntonEliatra <[email protected]>


          typo on cross-cluster page

Signed-off-by: AntonEliatra <[email protected]>

Contributor Author

AntonEliatra commented Apr 24, 2024

Thank you @ankitkala, that's been updated now

ankitkala approved these changes

View reviewed changes

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved


          Merge branch 'main' into proxy-config

33ef66e

hdhalter added 4 - Doc review and removed 3 - Tech review labels

Contributor

hdhalter commented Apr 25, 2024

Thanks for your thorough review, @ankitkala ! I'll push this through to doc review.

Naarcha-AWS reviewed

View reviewed changes

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

Naarcha-AWS reviewed

View reviewed changes

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

Naarcha-AWS reviewed

View reviewed changes

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

Naarcha-AWS requested changes

View reviewed changes

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

46f8eb4

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

Naarcha-AWS approved these changes

View reviewed changes

Collaborator

Naarcha-AWS left a comment

One small comment but otherwise LGTM

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

Naarcha-AWS added 5 - Editorial review and removed 4 - Doc review labels


          Update _search-plugins/cross-cluster-search.md

0ed716e

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

natebower reviewed

View reviewed changes

Collaborator

natebower left a comment

@AntonEliatra @Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

_search-plugins/cross-cluster-search.md Outdated Show resolved Hide resolved

AntonEliatra and others added 2 commits

May 10, 2024 08:54


          Apply suggestions from code review

f36f58d

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>


          updating proxy details as per comments

501ff88

Signed-off-by: AntonEliatra <[email protected]>

hdhalter assigned Naarcha-AWS

hdhalter added backport 2.14 and removed backport 2.13 labels


          Update cross-cluster-search.md

01eba28

Signed-off-by: Naarcha-AWS <[email protected]>

hdhalter added 3 - Done and removed 5 - Editorial review labels

hdhalter merged commit 00fa73e into opensearch-project:main

6 checks passed

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          adding proxy configuration #20231107 #20230503 in 4314 issue (#6952)

bc2bba0

* adding proxy configuration #20231107 #20230503 in 4314 issue

Signed-off-by: AntonEliatra <[email protected]>

* adding proxy configuration #20231107 #20230503 in 4314 issue

Signed-off-by: AntonEliatra <[email protected]>

* Update cross-cluster-search.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* adding prerequisite to cross-cluster page

Signed-off-by: AntonEliatra <[email protected]>

* typo on cross-cluster page

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update _search-plugins/cross-cluster-search.md

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating proxy details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Update cross-cluster-search.md

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 00fa73e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.14] adding proxy configuration #20231107 #20230503 in 4314 issue #7181

Merged

github-actions bot pushed a commit that referenced this pull request


          adding proxy configuration #20231107 #20230503 in 4314 issue (#6952) (#…

9a4de02

…7181)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hdhalter hdhalter left review comments

natebower natebower left review comments

Naarcha-AWS Naarcha-AWS approved these changes

stephen-crawford stephen-crawford approved these changes

ankitkala ankitkala approved these changes

kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

vagimeli Awaiting requested review from vagimeli

AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

epugh Awaiting requested review from epugh epugh is a code owner

Labels

3 - Done backport 2.14 security