Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds section on product quantization for docs #6926
Adds section on product quantization for docs #6926
Changes from 1 commit
4f1bd63
0370b85
548805b
167cb96
be1c836
255a25b
08194cb
0a0e105
83503a8
1e413bc
050064e
f2f42ee
10c35eb
22508e2
6d8e9d1
bda3d4f
7e4e956
3cf22dd
28acaac
5231b87
be1e447
c78bc75
036db27
08a9857
55bf87c
38aca8d
5591d88
2b51288
2c389a3
5b0f258
d054f3f
9cc412f
ff0bebc
5b68721
b15ac62
072f1e6
ead048e
2721679
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the line break formatting of lines 13--16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the line breaks so that editing would be easier and it doesnt impact rendering (i.e. it wouldnt be one line that rolls out of the screen). Is this incorrect to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's incorrect to enter line breaks. The site and OpenSearch Project doc team follow a specific formatting guide. I'll handle formatting the doc before moving it into editorial. https://github.com/opensearch-project/documentation-website/blob/main/FORMATTING_GUIDE.md
Check failure on line 19 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job
Check failure on line 195 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job
Check failure on line 210 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job
Check failure on line 211 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job
Check failure on line 218 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job
Check failure on line 222 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job
Check failure on line 224 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job
Check failure on line 225 in _search-plugins/knn/knn-vector-quantization.md
GitHub Actions / style-job