Clarifies that Data Prepper select_entries processor does not remove events #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation that events are not dropped. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
stephen-crawford and
epugh
as code owners
|
Can you clarify what you mean by, "... the events will not be removed from the pipeline"? |
As in, are we referring to the Data Prepper pipeline itself, or the database where the event originates? |
Naarcha-AWS
added
4 - Doc review
@Naarcha-AWS , I mean to say that they will not be removed from the Data Prepper pipeline. That is to say, this will not drop events similar to the |
Naarcha-AWS
reviewed
Apr 18, 2024
_data-prepper/pipelines/configuration/processors/select-entries.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Apr 18, 2024
_data-prepper/pipelines/configuration/processors/select-entries.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Apr 18, 2024
_data-prepper/pipelines/configuration/processors/select-entries.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
approved these changes
Apr 18, 2024
Naarcha-AWS
reviewed
Apr 18, 2024
_data-prepper/pipelines/configuration/processors/select-entries.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
…events (#6917) * Adds some clarity to the Data Prepper select_entries processor documentation that events are not dropped. Signed-off-by: David Venable <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: David Venable <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 8b71973) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently had some customers expect that
select_entrieswould also select events that match. This is not the case.This PR attempts to clarify the behavior so that customers better understand what happens when
select_whenis false.Issues Resolved
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.