Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code error on select_entries processor #6913

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Fix code error on select_entries processor #6913

merged 2 commits into from
Apr 9, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS
Copy link
Collaborator Author

@dlvenable: Can you take a look at this one?

@Naarcha-AWS Naarcha-AWS added backport 2.13 PR: Backport label for 2.13 3 - Tech review PR: Tech review in progress labels Apr 8, 2024
@Naarcha-AWS Naarcha-AWS self-assigned this Apr 8, 2024
dlvenable
dlvenable approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @Naarcha-AWS !

@Naarcha-AWS Naarcha-AWS merged commit e863e22 into main Apr 9, 2024
9 checks passed
@github-actions github-actions bot deleted the select_entries branch April 9, 2024 21:59
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 9, 2024
@github-actions
Fix code error on select_entries processor (#6913)
b3c3e8b 
Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit e863e22)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 9, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
@opensearch-trigger-bot
Fix code error on select_entries processor (#6913) (#6934)
6741cf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizsnyder lizsnyder lizsnyder approved these changes

@dlvenable dlvenable dlvenable approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@Naarcha-AWS Naarcha-AWS

Labels
3 - Tech review PR: Tech review in progress backport 2.13 PR: Backport label for 2.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naarcha-AWS @dlvenable @lizsnyder