-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for printing associated queries, and sample documents in notification message. #6866
Merged
Naarcha-AWS
merged 18 commits into
opensearch-project:main
from
AWSHurneyt:3.0-contextual-alerting
May 14, 2024
Merged
Added documentation for printing associated queries, and sample documents in notification message. #6866
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
98767e6
Added documentation for printing associated queries, and sample docum…
AWSHurneyt 1d6baf4
Merge branch 'main' into 3.0-contextual-alerting
AWSHurneyt 65a6e2c
Merge branch 'main' into 3.0-contextual-alerting
AWSHurneyt c479700
Merge branch 'main' into 3.0-contextual-alerting
AWSHurneyt db177e8
Merge branch 'main' into 3.0-contextual-alerting
Naarcha-AWS a2ae72f
Merge branch 'main' into 3.0-contextual-alerting
AWSHurneyt 220d17a
Merge branch 'main' into 3.0-contextual-alerting
AWSHurneyt 6561e38
Apply suggestions from code review
Naarcha-AWS 40f3722
Apply suggestions from code review
AWSHurneyt 964ee98
Revised draft.
AWSHurneyt dd6a436
Update _observing-your-data/alerting/triggers.md
Naarcha-AWS 0a59b93
Update _observing-your-data/alerting/triggers.md
Naarcha-AWS 4f60bbc
Update _observing-your-data/alerting/triggers.md
Naarcha-AWS 2fdffae
Update _observing-your-data/alerting/triggers.md
Naarcha-AWS 1983713
Apply suggestions from code review
Naarcha-AWS c697d19
Update _observing-your-data/alerting/triggers.md
Naarcha-AWS 2ce26c0
Apply suggestions from code review
Naarcha-AWS cf0f740
Apply suggestions from code review
Naarcha-AWS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for documentation reviewers:
The following sentence on line 146, calls out that the variable names for the "alerts" list is
newAlerts
for per bucket monitors, andalerts
for per document monitors.The example in this code block is for a per document monitor as, on line 188, the "alerts" list is accessed via
{{#ctx.alerts}}
instead of{{#ctx.newAlerts}}
. Does that seem clear enough, or would it be helpful to update the note on line 184 to call out that the example is for a per document monitor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets update line 184 and call it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised.