Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5166 Updating new roles and removing old roles #6826

Merged
merged 16 commits into from
Apr 10, 2024
Merged

5166 Updating new roles and removing old roles #6826

merged 16 commits into from
Apr 10, 2024

Conversation

leanneeliatra
Copy link
Contributor

@leanneeliatra leanneeliatra commented Apr 2, 2024 •
edited by hdhalter
Loading

Description

Updates to the users and roles page to make it updated with what the user sees when using OpenSearch v2.7

Issues Resolved

Closes [DOC] Openserach.org Users and roles docs are out of date #5166

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@leanneeliatra leanneeliatra changed the title [DRAFT] 5166 Updating new roles and removing old roles 5166 Updating new roles and removing old roles Apr 3, 2024
@leanneeliatra
Copy link
Contributor Author

@hdhalter this is ready for review please.cc @scrawfor99

@Naarcha-AWS Naarcha-AWS added the 3 - Tech review PR: Tech review in progress label Apr 3, 2024
@Naarcha-AWS Naarcha-AWS added the backport 2.13 PR: Backport label for 2.13 label Apr 3, 2024
stephen-crawford
stephen-crawford approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

_security/access-control/users-roles.md Outdated Show resolved Hide resolved
@leanneeliatra
Copy link
Contributor Author

@Naarcha-AWS this has been reviewed by Stephen, perhaps you can take a look? or flagging for next steps please @hdhalter

@Naarcha-AWS
Copy link
Collaborator

@leanneeliatra: I'll have some comments for your today.

@hdhalter
Copy link
Contributor

hdhalter commented Apr 8, 2024 •
edited
Loading

Thanks, @leanneeliatra! Can you please put the items in the table in alphabetical order? Also, can you make the TOC at the top collapsible? Here is the code:

<details closed markdown="block">
  <summary>
    Table of contents
  </summary>
  {: .text-delta }
- TOC
{:toc}
</details>

Naarcha-AWS and others added 2 commits April 8, 2024 14:29
@leanneeliatra
Copy link
Contributor Author

Thanks @hdhalter for providing the TOC code. I have made that change and also made the table listed in alphabetical order.

@hdhalter
Copy link
Contributor

hdhalter commented Apr 9, 2024

Thanks @hdhalter for providing the TOC code. I have made that change and also made the table listed in alphabetical order.

Thanks, @leanneeliatra ! The table looks good. For the TOC, please remove lines 39 and 40.

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels Apr 9, 2024
@leanneeliatra
Copy link
Contributor Author

leanneeliatra commented Apr 10, 2024 •
edited
Loading

Hi @hdhalter, I made that change, thank you.

I also moved the TOC up the page, to above the first section called out in the TOC.
To me this makes more sense than after Editing the roles.yml file.

natebower
natebower reviewed Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leanneeliatra @Naarcha-AWS Please see my changes and let me know if you have any questions. Thanks!

_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
@leanneeliatra @natebower
Apply suggestions from code review
32bdb09 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
@leanneeliatra
Copy link
Contributor Author

Thanks for that review @natebower, you picked up some great necessary edits there, much appreciated.

The changes have all been addressed and committed now.

@Naarcha-AWS Naarcha-AWS merged commit 694e159 into opensearch-project:main Apr 10, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2024
@github-actions @Naarcha-AWS @natebower
5166 Updating new roles and removing old roles (#6826)
a8a2940 
* updating new roles and removing old roles

Signed-off-by: [email protected] <[email protected]>

* remove uneeded roles

Signed-off-by: [email protected] <[email protected]>

* updating table values

Signed-off-by: [email protected] <[email protected]>

* reviewdog fix

Signed-off-by: [email protected] <[email protected]>

* Formatting edits.

Will complete other edits shortly.

Signed-off-by: Naarcha-AWS <[email protected]>

* table in alphabetical order and toc added in dropdown format

Signed-off-by: [email protected] <[email protected]>

* Remove whitespace from table, add action verbs.

Signed-off-by: Naarcha-AWS <[email protected]>

* removed undeeded toc lines

Signed-off-by: [email protected] <[email protected]>

* moved toc up

Signed-off-by: [email protected] <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 694e159)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 10, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@opensearch-trigger-bot
5166 Updating new roles and removing old roles (#6826) (#6937)
eb62125
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Apr 11, 2024
@hdhalter hdhalter mentioned this pull request Apr 11, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@Naarcha-AWS Naarcha-AWS Naarcha-AWS approved these changes

@stephen-crawford stephen-crawford stephen-crawford approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@Naarcha-AWS Naarcha-AWS

@leanneeliatra leanneeliatra

Labels
3 - Done Issue is done/complete backport 2.13 PR: Backport label for 2.13 security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Openserach.org Users and roles docs are out of date
5 participants
@leanneeliatra @Naarcha-AWS @hdhalter @stephen-crawford @natebower