fix(security): explicitly add keys required in security config #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotor
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
stephen-crawford
as code owners
Signed-off-by: shotor <[email protected]>
shotor
force-pushed
the
fix/explicit-security-config
branch
from
bb85192 to
5ad7dcf
Compare
|
@scrawfor99 - Can you please check for technical accuracy? Thanks! |
hdhalter
added
3 - Tech review
stephen-crawford
approved these changes
Apr 1, 2024
Naarcha-AWS
approved these changes
Apr 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Signed-off-by: shotor <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 301ca68) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
added a commit
that referenced
this pull request
Apr 2, 2024
#6820) (cherry picked from commit 301ca68) Signed-off-by: shotor <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
config.dynamicandconfig.dynamic.authcparts were left out in these files. And it took me hours to realize I was missing those and my auth config wasn't being picked up because of it.Also if you don't have the
_metakey thensecurityadmin.shwill fail.I think it's better to add them explicitly, to potentially save someone else some time.
Issues Resolved
Solved 1 of the many issues I'm having in this community post, namely that my authentication config wasn't being picked up at all.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.