-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Methods Examples Provided 20231026 #6756
HTTP Methods Examples Provided 20231026 #6756
Conversation
…s of HTTP methods. Signed-off-by: [email protected] <[email protected]>
@hdhalter @scrawfor99 @Naarcha-AWS, this PR is ready for a review please. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this addresses the feedback, but I do know that we lost the description. We also need to make sure to follow the API template.
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Hi all, I have addressed all the comments now for this PR.
|
That's great @Naarcha-AWS thanks, I have made that small change and addressed all other comments now. |
Final changes from sync call & confirmations from @Naarcha-AWS
Points addressed and edits made in the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leanneeliatra @Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!
|
||
## Simple roles | ||
|
||
Document-level security uses the OpenSearch query DSL to define which documents a role grants access to. In OpenSearch Dashboards, choose an index pattern and provide a query in the **Document level security** section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DSL should be defined on first appearance.
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]>
Thank you @natebower, I have addressed the editorial review comments and alos the comments from @Naarcha-AWS from our call. Thank you both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leanneeliatra @Naarcha-AWS A few corrections, please. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]>
Brilliant @natebower thank you, those have been addressed. |
* updating the doucumentation to be more descriptive and adding examples of HTTP methods. Signed-off-by: [email protected] <[email protected]> * actual runnable examples given to the user for greater clarity Signed-off-by: [email protected] <[email protected]> * removing duplication added in error and addressing review comments Signed-off-by: [email protected] <[email protected]> * adding back the first 2 sections Signed-off-by: [email protected] <[email protected]> * fixing formatting Signed-off-by: [email protected] <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * updated introduction scentance Signed-off-by: [email protected] <[email protected]> * Update _api-reference/document-apis/index-document.md Signed-off-by: Naarcha-AWS <[email protected]> * Update index-document.md Signed-off-by: leanneeliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * addressing review comments and editorial review Signed-off-by: [email protected] <[email protected]> * Update _security/access-control/document-level-security.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Update _security/access-control/document-level-security.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit e06a84d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
A customer submitted a query in relation to this page of the documentation:
https://opensearch.org/docs/latest/api-reference/document-apis/index-document
Customer query: please give a full detailed document with method type. what use put method? like this if describe that can easy to use a developer this apies.-x
Answer to customers query:
In the documentation there is a list of HTTP method examples. The examples are not explained and they cannot be directly inputted to test them.
Fix: Add clarification to the documentation. Describe in more detail what the HTTP methods are used for. Give actual examples the user can follow along with in a more stepwise manner, give examples the user can copy paste into the dev tools and run them.
Issues Resolved
This ticket addresses one part of #4314
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.