Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Methods Examples Provided 20231026 #6756

Conversation

leanneeliatra
Copy link
Contributor

@leanneeliatra leanneeliatra commented Mar 21, 2024

Description

A customer submitted a query in relation to this page of the documentation:
https://opensearch.org/docs/latest/api-reference/document-apis/index-document

Customer query: please give a full detailed document with method type. what use put method? like this if describe that can easy to use a developer this apies.-x

Answer to customers query:
In the documentation there is a list of HTTP method examples. The examples are not explained and they cannot be directly inputted to test them.

Fix: Add clarification to the documentation. Describe in more detail what the HTTP methods are used for. Give actual examples the user can follow along with in a more stepwise manner, give examples the user can copy paste into the dev tools and run them.

Issues Resolved
This ticket addresses one part of #4314

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@leanneeliatra leanneeliatra changed the title [DRAFT] HTTP Methods Examples Provided 20231026 HTTP Methods Examples Provided 20231026 Mar 22, 2024
@leanneeliatra
Copy link
Contributor Author

@hdhalter @scrawfor99 @Naarcha-AWS, this PR is ready for a review please. Thank you.

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Mar 22, 2024
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this addresses the feedback, but I do know that we lost the description. We also need to make sure to follow the API template.

_api-reference/document-apis/index-document.md Outdated Show resolved Hide resolved
@leanneeliatra
Copy link
Contributor Author

leanneeliatra commented Mar 28, 2024

Hi all, I have addressed all the comments now for this PR.
To summarise, these are the recent comments and the updated status:

  1. We lost the description of the index, add back in the first 2 sections. cc @hdhalter
    This is amended., see the updated page
  2. We should make sure we follow the API template as per this page cc @hdhalter
    I'm not sure how I am currently deviating. Are the current changes okay, or can you inform me of what it is I am missing please, as I’m not certain from reviewing the page, thank you.
  3. We had repeated a section of code here, @scrawfor99 & @Naarcha-AWS picked up on this, thanks
    this is amended.
  4. I have capitalised the word Permissions in Index Permissions amended cc @scrawfor99
  5. The hypen in document-level and field-level can stay, in keeping with the rest of the page. cc @scrawfor99

@leanneeliatra
Copy link
Contributor Author

One small comment then we'll pass it to editorial.

That's great @Naarcha-AWS thanks, I have made that small change and addressed all other comments now.
To check also, should we leave in the section ## Adding a sample index and documents to use the HTTP methods or do you think it's a bit too much information?
Thanks

@leanneeliatra
Copy link
Contributor Author

leanneeliatra commented Apr 3, 2024

Final changes from sync call & confirmations from @Naarcha-AWS

  1. Change Hamburger to actions menu.
  2. curl based commands through terminal
  3. Comment should we leave in the section ## Adding a sample index and documents to use the HTTP methods this section is okay to leave in from Nates review.

Points addressed and edits made in the code

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leanneeliatra @Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!

_api-reference/document-apis/index-document.md Outdated Show resolved Hide resolved
_api-reference/document-apis/index-document.md Outdated Show resolved Hide resolved
_api-reference/document-apis/index-document.md Outdated Show resolved Hide resolved
_api-reference/document-apis/index-document.md Outdated Show resolved Hide resolved
_api-reference/document-apis/index-document.md Outdated Show resolved Hide resolved
_api-reference/document-apis/index-document.md Outdated Show resolved Hide resolved
_security/access-control/document-level-security.md Outdated Show resolved Hide resolved
_security/access-control/document-level-security.md Outdated Show resolved Hide resolved

## Simple roles

Document-level security uses the OpenSearch query DSL to define which documents a role grants access to. In OpenSearch Dashboards, choose an index pattern and provide a query in the **Document level security** section:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSL should be defined on first appearance.

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Apr 4, 2024
@leanneeliatra
Copy link
Contributor Author

@leanneeliatra @Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!

Thank you @natebower, I have addressed the editorial review comments and alos the comments from @Naarcha-AWS from our call.

Thank you both.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leanneeliatra @Naarcha-AWS A few corrections, please. Thanks!

@leanneeliatra
Copy link
Contributor Author

@leanneeliatra @Naarcha-AWS A few corrections, please. Thanks!

Brilliant @natebower thank you, those have been addressed.

@Naarcha-AWS Naarcha-AWS added the backport 2.13 PR: Backport label for 2.13 label Apr 5, 2024
@Naarcha-AWS Naarcha-AWS merged commit e06a84d into opensearch-project:main Apr 5, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2024
* updating the doucumentation to be more descriptive and adding examples of HTTP methods.

Signed-off-by: [email protected] <[email protected]>

* actual runnable examples given to the user for greater clarity

Signed-off-by: [email protected] <[email protected]>

* removing duplication added in error and addressing review comments

Signed-off-by: [email protected] <[email protected]>

* adding back the first 2 sections

Signed-off-by: [email protected] <[email protected]>

* fixing formatting

Signed-off-by: [email protected] <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* updated introduction scentance

Signed-off-by: [email protected] <[email protected]>

* Update _api-reference/document-apis/index-document.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Update index-document.md

Signed-off-by: leanneeliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* addressing review comments and editorial review

Signed-off-by: [email protected] <[email protected]>

* Update _security/access-control/document-level-security.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update _security/access-control/document-level-security.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit e06a84d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete backport 2.13 PR: Backport label for 2.13 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants