-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for retry settings for Remote reindex #6726
Conversation
Signed-off-by: Ankit Kala <[email protected]>
Signed-off-by: Ankit Kala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ankitkala! A couple of suggestions.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Ankit Kala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor nit about "follow," per our discussion. But your call 😄
Slightly confused here. I did pick all the suggested changes. Is there anything missing? |
Let's leave as is per discussion with @natebower. Thanks, @ankitkala. Ready to merge now. |
…roject#6726) * Add documentation for retry settings for Remote reindex Signed-off-by: Ankit Kala <[email protected]> * Fixing the typo Signed-off-by: Ankit Kala <[email protected]> * Addressing PR comments Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Ankit Kala <[email protected]> --------- Signed-off-by: Ankit Kala <[email protected]> Co-authored-by: kolchfa-aws <[email protected]>
Description
Add documentation for retry settings for Remote reindex
Issues Resolved
Closes #6674
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.