Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for kuromoji_completion filter #6699

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

msfroh
Copy link
Contributor

@msfroh msfroh commented Mar 15, 2024

Description

Adds a documentation line for the kuromoji_completion filter, and updates links to Lucene docs to 9_10_0 paths.

Issues Resolved

Closes #6552

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@msfroh msfroh force-pushed the kuromoji_completion branch from 845da44 to a1258ae Compare March 15, 2024 20:54
@msfroh
Copy link
Contributor Author

msfroh commented Mar 15, 2024

Huh... Vale doesn't like my use of the word "romanized", but it's a perfectly cromulent word: https://en.wikipedia.org/wiki/Romanization

@hdhalter
Copy link
Contributor

Thank you, @msfroh !

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.13.0 labels Mar 15, 2024
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @msfroh! Just one suggestion.

_analyzers/token-filters/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_analyzers/token-filters/index.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws merged commit 932a175 into opensearch-project:main Mar 20, 2024
3 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 4 - Doc review PR: Doc review in progress labels Mar 20, 2024
CaptainDredge pushed a commit to CaptainDredge/documentation-website that referenced this pull request Mar 22, 2024
…6699)

* Add documentation for kuromoji_completion filter

Signed-off-by: Michael Froh <[email protected]>

* Update _analyzers/token-filters/index.md

Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add documentation for kuromoji_completion analyzer and filter
4 participants