-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more details to cross-cluster page #20230811 #20231102 #20230804 #6657
Merged
Naarcha-AWS
merged 21 commits into
opensearch-project:main
from
AntonEliatra:adding-details-for-ccs
Apr 5, 2024
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
60695ac
adding more details to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra 955715b
adding more details to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra 5cf765a
adding more details to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra b746ce7
adding more details to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra 57b9bf2
adding more details to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra 7e0121d
adding more details to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra e2bf2d2
moving cross cluster search to new page #20230811 #20231102 #20230804
AntonEliatra ee357c7
moving cross cluster search to new page #20230811 #20231102 #20230804
AntonEliatra ff743b3
Light edits
hdhalter 68ea214
A few more tweaks
hdhalter d66fecf
Merge branch 'main' into adding-details-for-ccs
Naarcha-AWS ab5f935
Apply suggestions from code review
Naarcha-AWS 08abe61
Merge branch 'main' into adding-details-for-ccs
Naarcha-AWS f29373e
Apply suggestions from code review
AntonEliatra 9bb46e9
fixes to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra 8a553eb
fixes to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra e4614ac
Merge branch 'opensearch-project:main' into adding-details-for-ccs
AntonEliatra 97934f2
adding more details to cross-cluster page #20230811 #20231102 #20230804
AntonEliatra c4a9e3b
Update _search-plugins/cross-cluster-search.md
AntonEliatra b463691
Merge branch 'main' into adding-details-for-ccs
Naarcha-AWS 6028bc1
Merge branch 'main' into adding-details-for-ccs
Naarcha-AWS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntonEliatra - You'll want to use Callouts for this type of info, not Labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add another H2 above this section? Something like, "Configuring cross-cluster search from Dashboards"? (I would rethink the other headings, too.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdhalter I dont think we discussed this today, can you elaborated please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one screenshot just to demonstrate that all of the curl commands can be executed from dev tools, Do you mean to add more screenshots and expand on this?