Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove_by_pattern ingest processor #6295

Merged
merged 12 commits into from
Jan 31, 2024
Merged

Add remove_by_pattern ingest processor #6295

merged 12 commits into from
Jan 31, 2024

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Jan 30, 2024 •
edited by hdhalter
Loading

Description

This PR documents the usage of the new added remove_by_pattern ingest processor.

Issues Resolved

Fixes #6207

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Copy link
Contributor Author

Hi @vagimeli , please also help to review this PR, even though the code PR in OpenSearch-core project has not been merged yet, we can review this document PR in advance and merge this PR after the code PR is merged.

@gaobinlong
Add more description
c488cdc 
Signed-off-by: gaobinlong <[email protected]>
@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.12.0 labels Jan 30, 2024
vagimeli
vagimeli approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@vagimeli vagimeli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaobinlong Thank you for putting up the PR. Some edits for your approval. I'll move this to editorial review.

_ingest-pipelines/processors/remove_by_pattern.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/remove_by_pattern.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/remove_by_pattern.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/remove_by_pattern.md Outdated Show resolved Hide resolved
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Jan 30, 2024
gaobinlong and others added 5 commits January 31, 2024 10:36
@gaobinlong @vagimeli
Update _ingest-pipelines/processors/remove_by_pattern.md
d758e0b 
Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
@gaobinlong @vagimeli
Update _ingest-pipelines/processors/remove_by_pattern.md
a0b5785 
Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
@gaobinlong @vagimeli
Update _ingest-pipelines/processors/remove_by_pattern.md
a40950c 
Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
@gaobinlong @vagimeli
Update _ingest-pipelines/processors/remove_by_pattern.md
1487f78 
Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
@gaobinlong
Fix typos
142acdd 
Signed-off-by: gaobinlong <[email protected]>
natebower
natebower reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Just a few changes. Thanks!

_ingest-pipelines/processors/remove_by_pattern.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/remove_by_pattern.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/remove_by_pattern.md Outdated Show resolved Hide resolved
vagimeli and others added 3 commits January 31, 2024 11:10
@vagimeli @natebower
Update _ingest-pipelines/processors/remove_by_pattern.md
6f51628 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/remove_by_pattern.md
26937a1 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/remove_by_pattern.md
e7674fa 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Jan 31, 2024
@vagimeli vagimeli merged commit 99ed213 into opensearch-project:main Jan 31, 2024
3 checks passed
@hdhalter hdhalter changed the title [Doc] Add remove_by_pattern ingest processor Add remove_by_pattern ingest processor Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@vagimeli vagimeli vagimeli approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

Assignees

@vagimeli vagimeli

Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Add remove_by_pattern ingest processor
4 participants
@gaobinlong @natebower @vagimeli @hdhalter