Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selective download feature to Data Prepper sources section #6247

Merged
merged 28 commits into from
Jun 27, 2024

Conversation

vagimeli
Copy link
Contributor

Description

Add selective download feature to Data Prepper sources section

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added 2 - In progress Issue/PR: The issue or PR is in progress. data-prepper Content gap labels Jan 23, 2024
@vagimeli vagimeli self-assigned this Jan 23, 2024
@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress 2 - In progress Issue/PR: The issue or PR is in progress. and removed 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Tech review PR: Tech review in progress labels Jan 24, 2024
@vagimeli
Copy link
Contributor Author

@dlvenable Please review this use case PR at your availability. I've put it under Data Prepper S3 sources content. If it's not the proper navigation, let me know where you think it best fits. Thank you, Melissa

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
@@ -0,0 +1,54 @@
---
layout: default
title: Selective download
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify this title? Something like "Selective download for S3 sources?"

@vagimeli
Copy link
Contributor Author

vagimeli commented Mar 6, 2024

@dlvenable At your availability, will you review this use case? It's one of the two last use cases we're transferring from OpenSearch Ingestion. Thank you, Melissa

@vagimeli vagimeli requested a review from epugh as a code owner April 4, 2024 19:30
@vagimeli
Copy link
Contributor Author

vagimeli commented Apr 9, 2024

@dlvenable Following up to get your tech review on this use case carryover from OpenSearch Service Ingestion to Data Prepper. Once we have your approval, I can move this forward to editorial and get it published.

vagimeli and others added 5 commits May 24, 2024 13:31
Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added Needs SME Waiting on input from subject matter expert and removed 4 - Doc review PR: Doc review in progress labels Jun 10, 2024
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress backport 2.15 and removed Needs SME Waiting on input from subject matter expert backport 2.14 PR: Backport label for 2.14 labels Jun 26, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!

@@ -20,15 +19,14 @@ The following diagram shows the overall architecture of the components involved.

<img src="{{site.url}}{{site.baseurl}}/images/data-prepper/s3-source/s3-architecture.jpg" alt="S3 source architecture">{: .img-fluid}

The flow of data is as follows.
The data flow involving the components is as follows:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The data flow involving the components" => "The component data flow"?

_data-prepper/common-use-cases/s3-logs.md Outdated Show resolved Hide resolved
_data-prepper/common-use-cases/s3-logs.md Outdated Show resolved Hide resolved
_data-prepper/common-use-cases/s3-logs.md Outdated Show resolved Hide resolved
_data-prepper/common-use-cases/s3-logs.md Outdated Show resolved Hide resolved
Refer to user guides [Filtering and retrieving data using Amazon S3 Select](https://docs.aws.amazon.com/AmazonS3/latest/userguide/selecting-content-from-objects.html) and [SQL reference for Amazon S3 Select](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-select-sql-reference.html) for comprehensive information about using Amazon S3 Select.
{: .note}

The following example pipeline retrieves all data S3 objects encoded in the Parquet File Format:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either "from" should follow "data", or "data" should be removed.

_data-prepper/common-use-cases/s3-logs.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
vagimeli and others added 5 commits June 27, 2024 10:49
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli merged commit a673b24 into main Jun 27, 2024
6 checks passed
@vagimeli vagimeli deleted the selective-download branch June 27, 2024 18:16
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 27, 2024
* Add feature to this section

Signed-off-by: Melissa Vagi <[email protected]>

* add content

Signed-off-by: Melissa Vagi <[email protected]>

* Copy edits

Signed-off-by: Melissa Vagi <[email protected]>

* Update selective-download.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review comments

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review comments

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: David Venable <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit a673b24)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra pushed a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this pull request Jul 24, 2024
…earch-project#6247)

* Add feature to this section

Signed-off-by: Melissa Vagi <[email protected]>

* add content

Signed-off-by: Melissa Vagi <[email protected]>

* Copy edits

Signed-off-by: Melissa Vagi <[email protected]>

* Update selective-download.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review comments

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review comments

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: David Venable <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: [email protected] <[email protected]>
sandervandegeijn pushed a commit to sandervandegeijn/documentation-website that referenced this pull request Jul 30, 2024
…earch-project#6247)

* Add feature to this section

Signed-off-by: Melissa Vagi <[email protected]>

* add content

Signed-off-by: Melissa Vagi <[email protected]>

* Copy edits

Signed-off-by: Melissa Vagi <[email protected]>

* Update selective-download.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review comments

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review comments

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: David Venable <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: David Venable <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Sander van de Geijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants