Create or Update alias API supports must_exist parameter #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower and
dlvenable
as code owners
|
Thanks for adding this PR, @gaobinlong! Is it ready for a doc review? |
hdhalter
added
release-notes
vagimeli
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
@gaobinlong Please see my doc review edits to make sure I've retained the intended meaning. I'll move this PR into editorial review following your review. Thanks, Melissa
Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: gaobinlong <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: gaobinlong <[email protected]>
The suggested change looks good to me, I've changed that, thanks! |
vagimeli
added
5 - Editorial review
Add copy tags
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
vagimeli
added
3 - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In version 2.12.0, we enable the parameter must_exist for the Remove action in Create/Update aliases API, this PR documents the usage.
Issues Resolved
Fixes #6124
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.