Added master_timeout parameter to CAT segments #624
Conversation
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
added
v2.0.0
v1.3.0
|
Should we have two versions of this? One for 1.3, which still uses |
|
So, it's the same parameter but it's named differently in 2.0? If so, I can create two different versions. |
Yeah, I believe that's a breaking change introduced in 2.0. You can look at #513 to see the exact syntax for what |
| @@ -46,6 +46,7 @@ In addition to the [common URL parameters]({{site.url}}{{site.baseurl}}/opensear | |||
| Parameter | Type | Description | |||
| :--- | :--- | :--- | |||
| bytes | Byte size | Specify the units for byte size. For example, `7kb` or `6gb`. For more information, see [Supported units]({{site.url}}{{site.baseurl}}/opensearch/units/).. | |||
| master_timeout | Time | The amount of time to wait for a connection to the master node. Default is 30 seconds. | |||
There was a problem hiding this comment.
Change master_timeout to cluster_manager_timeout, to fit our new nomenclature as described in #450
There was a problem hiding this comment.
And as Keith described, let's make a separate PR for 1.3
There was a problem hiding this comment.
OK thank you. Will do.
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Fixes #486
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.