-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shadow to version selector panel when left nav is scrolled #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
requested review from
hdhalter,
Naarcha-AWS,
vagimeli,
AMoo-Miki and
natebower
as code owners
January 16, 2024 15:13
hdhalter
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
kolchfa-aws
added
backport 1.3
PR: Backport label for v1.3.x
backport 2.0
PR: Backport label for v2.0.x
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
backport 2.5
PR: Backport label for 2.5
backport 2.6
PR: Backport label for 2.6
backport 2.7
PR: Backport label for 2.7
backport 2.8
PR: Backport label for 2.8
backport 2.9
PR: Backport label for 2.9
backport 2.10
PR: Backport label for 2.10
backport 2.11
PR: Backport label for 2.11
labels
Jan 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jan 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add shadow to version selector panel when scrolling Signed-off-by: Fanit Kolchina <[email protected]> * Change shadow size Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit e7fc108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6166) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6167) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6168) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6169) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6170) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6171) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6172) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6173) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6174) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6175) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6176) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6177) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Jan 16, 2024
#6178) * Add shadow to version selector panel when scrolling * Change shadow size --------- (cherry picked from commit e7fc108) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.3
PR: Backport label for v1.3.x
backport 2.0
PR: Backport label for v2.0.x
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
backport 2.5
PR: Backport label for 2.5
backport 2.6
PR: Backport label for 2.6
backport 2.7
PR: Backport label for 2.7
backport 2.8
PR: Backport label for 2.8
backport 2.9
PR: Backport label for 2.9
backport 2.10
PR: Backport label for 2.10
backport 2.11
PR: Backport label for 2.11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shadow to version selector panel when left nav is scrolled
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.