-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickstart to include dashboards #6004
Conversation
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need to check if the new home page needs to be configured. technically there are integration points within the home page to avoid breaking changes. but it is the home page so even breakages shouldn't be too big of an issue.
_dashboards/quickstart.md
Outdated
2. Choose **Add data** to add the datasets, as shown in the following image. | ||
- **Enhanced user experience:** Improves your experience by incorporating intuitive navigation, streamlined workflows, and a visually appealing interface. | ||
- **Optimized data accessibility:** Presents critical information in a more effective manner, making it easier for you to interpret and analyze data. | ||
- **Responsive design for multi-platform access:** Prioritizes responsive design principles, ensuring seamless access and functionality across various devices and screen sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need to vet this. we don't have any visual regression tests for verifying this. could be accurate now but wrong and we wont know it automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSFishy Will you review these lines to make sure the content is accurate? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is accurate. The page extensively uses OUI and properly utilizes the responsive aspects of it, so it should look good on all page sizes. The only disclaimer would be that all within sections are completely owned by plugins, so while the current homepage is responsive, there is not really any guarantee that it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the new homepage layout will not be default, but rather will be behind a switch, can we adjust the docs accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbeckler Are you asking that we put in some text around the new Discover toggle (Data Explorer) needing to be activated by the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSFishy , can you take a look at this and confirm that the homepage plan for 2.12 (keeping current as default and adding a setting to try out the new one) is consistent with these docs changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli The new homepage has its own separate toggle from the Discover/Data Explorer toggle. I think it defaults to old homepage. I'm also not sure if the PR will make it in for 2.12 as it's still Draft: opensearch-project/OpenSearch-Dashboards#5613
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbeckler We have specific Discover documentation that I can update when it's ready. this quickstart is intended to cover OpenSearch Dashboards tools generally. Is there any specific information we should remove? Currently, the OpenSearch Playground shows the updates, so I think we need to update the quickstart for relevancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgcreative Will you review the updates at your availability to make sure the UX topics and screenshots are appropriately captured? Thank you.
@brijos This is the PR for doc updates to the Quickstart for Dashboards redesign updates |
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
@natebower Thank you for your rewrites. You tightened the writing :) I accepted your suggestions. |
Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli Assuming all my comments/changes were clear, we should be good to go (apologies for accidentally closing and reopening). LGTM!
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli Additional modified content is now edited.
|
||
- Install [OpenSearch Dashboards](https://opensearch.org/downloads.html). | ||
- Add sample data or import your own data into OpenSearch. Go to [OpenSearch Dashboards quickstart guide]({{site.url}}{{site.baseurl}}/dashboards/quickstart/) to learn about adding sample datasets. Go to [Managing indexes]({{site.url}}{{site.baseurl}}/im-plugin/index/) to learn about importing your own data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add sample data or import your own data into OpenSearch. Go to [OpenSearch Dashboards quickstart guide]({{site.url}}{{site.baseurl}}/dashboards/quickstart/) to learn about adding sample datasets. Go to [Managing indexes]({{site.url}}{{site.baseurl}}/im-plugin/index/) to learn about importing your own data. | |
- Add sample data or import your own data into OpenSearch. Go to the [OpenSearch Dashboards quickstart guide]({{site.url}}{{site.baseurl}}/dashboards/quickstart/) to learn about adding sample datasets. Go to [Managing indexes]({{site.url}}{{site.baseurl}}/im-plugin/index/) to learn about importing your own data. |
|
||
<img src="{{site.url}}{{site.baseurl}}/images/dashboards/visualization-flight.png" alt="Data visualization of flight sample data field destination" width="700"/> | ||
|
||
## Setting alerts | ||
|
||
You can set alerts to notify you when your data changes beyond the thresholds you define. To learn more about using **Discover** to create and manage alerts, see [Alerting dashboards and visualizations]({{site.url}}{{site.baseurl}}/observing-your-data/alerting/dashboards-alerting/). | ||
Set alerts to notify you when your data changes beyond the thresholds you define. Go to [Alerting dashboards and visualizations]({{site.url}}{{site.baseurl}}/observing-your-data/alerting/dashboards-alerting/) to learn about creating and managing alerts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep "You can set", given that this is directly under a heading?
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Thank you! |
Signed-off-by: Melissa Vagi <[email protected]>
Update quickstart and discover content for relevancy to current Dashboards 2.12 --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 7152f90) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Update quickstart and discover content for relevancy to current Dashboards 2.12 --------- (cherry picked from commit 7152f90) Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Update quickstart and discover content for relevancy to current Dashboards 2.12 --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Description
Revises quickstart to include redesign homepage and update tutorial screenshots
Issues Resolved
Addresses Dark Mode only in #6344
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.