Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart to include dashboards #6004

Merged
merged 97 commits into from
Feb 29, 2024
Merged

Update quickstart to include dashboards #6004

merged 97 commits into from
Feb 29, 2024

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Dec 28, 2023

Description

Revises quickstart to include redesign homepage and update tutorial screenshots

Issues Resolved

Addresses Dark Mode only in #6344

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli added 2 - In progress Issue/PR: The issue or PR is in progress. v2.12.0 labels Dec 28, 2023
@vagimeli vagimeli self-assigned this Dec 28, 2023
@vagimeli vagimeli linked an issue Dec 28, 2023 that may be closed by this pull request
4 tasks
@vagimeli vagimeli added the 3 - Tech review PR: Tech review in progress label Jan 5, 2024
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to check if the new home page needs to be configured. technically there are integration points within the home page to avoid breaking changes. but it is the home page so even breakages shouldn't be too big of an issue.

_dashboards/quickstart.md Outdated Show resolved Hide resolved
2. Choose **Add data** to add the datasets, as shown in the following image.
- **Enhanced user experience:** Improves your experience by incorporating intuitive navigation, streamlined workflows, and a visually appealing interface.
- **Optimized data accessibility:** Presents critical information in a more effective manner, making it easier for you to interpret and analyze data.
- **Responsive design for multi-platform access:** Prioritizes responsive design principles, ensuring seamless access and functionality across various devices and screen sizes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to vet this. we don't have any visual regression tests for verifying this. could be accurate now but wrong and we wont know it automatically.

Copy link
Contributor Author

@vagimeli vagimeli Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BSFishy Will you review these lines to make sure the content is accurate? Thanks!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is accurate. The page extensively uses OUI and properly utilizes the responsive aspects of it, so it should look good on all page sizes. The only disclaimer would be that all within sections are completely owned by plugins, so while the current homepage is responsive, there is not really any guarantee that it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the new homepage layout will not be default, but rather will be behind a switch, can we adjust the docs accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbeckler Are you asking that we put in some text around the new Discover toggle (Data Explorer) needing to be activated by the user?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BSFishy , can you take a look at this and confirm that the homepage plan for 2.12 (keeping current as default and adding a setting to try out the new one) is consistent with these docs changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli The new homepage has its own separate toggle from the Discover/Data Explorer toggle. I think it defaults to old homepage. I'm also not sure if the PR will make it in for 2.12 as it's still Draft: opensearch-project/OpenSearch-Dashboards#5613

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbeckler We have specific Discover documentation that I can update when it's ready. this quickstart is intended to cover OpenSearch Dashboards tools generally. Is there any specific information we should remove? Currently, the OpenSearch Playground shows the updates, so I think we need to update the quickstart for relevancy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgcreative Will you review the updates at your availability to make sure the UX topics and screenshots are appropriately captured? Thank you.

@hdhalter hdhalter removed the 2 - In progress Issue/PR: The issue or PR is in progress. label Jan 17, 2024
@vagimeli
Copy link
Contributor Author

@brijos This is the PR for doc updates to the Quickstart for Dashboards redesign updates

vagimeli and others added 4 commits February 27, 2024 13:55
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Copy link
Contributor Author

@vagimeli As you'll see, I edited and reorganized this pretty liberally, so take a look and let me know if you have any questions about my changes (or if you disagree 😄). Please tag me when complete so that I can reread and approve. Thanks!

@natebower Thank you for your rewrites. You tightened the writing :) I accepted your suggestions.

@natebower
Copy link
Collaborator

@vagimeli As you'll see, I edited and reorganized this pretty liberally, so take a look and let me know if you have any questions about my changes (or if you disagree 😄). Please tag me when complete so that I can reread and approve. Thanks!

@natebower Thank you for your rewrites. You tightened the writing :) I accepted your suggestions.

@natebower natebower closed this Feb 28, 2024
@natebower natebower reopened this Feb 28, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Assuming all my comments/changes were clear, we should be good to go (apologies for accidentally closing and reopening). LGTM!

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Additional modified content is now edited.


- Install [OpenSearch Dashboards](https://opensearch.org/downloads.html).
- Add sample data or import your own data into OpenSearch. Go to [OpenSearch Dashboards quickstart guide]({{site.url}}{{site.baseurl}}/dashboards/quickstart/) to learn about adding sample datasets. Go to [Managing indexes]({{site.url}}{{site.baseurl}}/im-plugin/index/) to learn about importing your own data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add sample data or import your own data into OpenSearch. Go to [OpenSearch Dashboards quickstart guide]({{site.url}}{{site.baseurl}}/dashboards/quickstart/) to learn about adding sample datasets. Go to [Managing indexes]({{site.url}}{{site.baseurl}}/im-plugin/index/) to learn about importing your own data.
- Add sample data or import your own data into OpenSearch. Go to the [OpenSearch Dashboards quickstart guide]({{site.url}}{{site.baseurl}}/dashboards/quickstart/) to learn about adding sample datasets. Go to [Managing indexes]({{site.url}}{{site.baseurl}}/im-plugin/index/) to learn about importing your own data.

_dashboards/discover/index-discover.md Outdated Show resolved Hide resolved
_dashboards/discover/index-discover.md Outdated Show resolved Hide resolved

<img src="{{site.url}}{{site.baseurl}}/images/dashboards/visualization-flight.png" alt="Data visualization of flight sample data field destination" width="700"/>

## Setting alerts

You can set alerts to notify you when your data changes beyond the thresholds you define. To learn more about using **Discover** to create and manage alerts, see [Alerting dashboards and visualizations]({{site.url}}{{site.baseurl}}/observing-your-data/alerting/dashboards-alerting/).
Set alerts to notify you when your data changes beyond the thresholds you define. Go to [Alerting dashboards and visualizations]({{site.url}}{{site.baseurl}}/observing-your-data/alerting/dashboards-alerting/) to learn about creating and managing alerts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep "You can set", given that this is directly under a heading?

vagimeli and others added 2 commits February 29, 2024 09:38
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Copy link
Contributor Author

@vagimeli Assuming all my comments/changes were clear, we should be good to go (apologies for accidentally closing and reopening). LGTM!

Thank you!

@vagimeli vagimeli added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Feb 29, 2024
@vagimeli vagimeli merged commit 7152f90 into main Feb 29, 2024
5 checks passed
@vagimeli vagimeli deleted the quickstart-redesign branch February 29, 2024 16:50
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 29, 2024
Update quickstart and discover content for relevancy to current Dashboards 2.12

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 7152f90)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Feb 29, 2024
Update quickstart and discover content for relevancy to current Dashboards 2.12

---------




(cherry picked from commit 7152f90)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
oeyh pushed a commit to oeyh/documentation-website that referenced this pull request Mar 14, 2024
Update quickstart and discover content for relevancy to current Dashboards 2.12

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete backport 2.12 PR: Backport label for 2.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants