Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add sort processor documentation #5990

Merged
merged 15 commits into from
Jun 11, 2024
Merged

[DOC] Add sort processor documentation #5990

merged 15 commits into from
Jun 11, 2024

Conversation

vagimeli
Copy link
Contributor

Description

Closes content gap

Issues Resolved

#4647

Checklist

  • [ x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli added Needs SME Waiting on input from subject matter expert Content gap labels Dec 22, 2023
@vagimeli vagimeli self-assigned this Dec 22, 2023
@vagimeli
Copy link
Contributor Author

@hdhalter We need a dev to take the first pass at drafting this content. I can support them in refining the content and getting it through the documentation process. The ingest processor template is provided with this PR, so it should help the dev get started. Thanks!

@vagimeli vagimeli marked this pull request as draft February 15, 2024 21:22
@vagimeli vagimeli marked this pull request as ready for review May 28, 2024 20:54
@vagimeli
Copy link
Contributor Author

@gaobinlong This PR is ready for your review at your availability. Thank you for all your technical reviews on these topics!

@vagimeli vagimeli added backport 2.14 PR: Backport label for 2.14 3 - Tech review PR: Tech review in progress and removed Needs SME Waiting on input from subject matter expert labels May 28, 2024
Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
_ingest-pipelines/processors/sort.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/sort.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/sort.md Outdated Show resolved Hide resolved
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels Jun 7, 2024
@vagimeli vagimeli removed the 5 - Editorial review PR: Editorial review in progress label Jun 10, 2024
@vagimeli
Copy link
Contributor Author

vagimeli commented Jun 10, 2024

@natebower Upon completing your review, will you approve for merging? This is part of the series that I opened PRs and co-authored with dev, but can't approve. Thank you.

@vagimeli vagimeli added the 5 - Editorial review PR: Editorial review in progress label Jun 10, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli LGTM with a few minor changes. Thanks!

_ingest-pipelines/processors/sort.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/sort.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/sort.md Outdated Show resolved Hide resolved
vagimeli and others added 4 commits June 11, 2024 08:41
@vagimeli vagimeli merged commit 28f6642 into main Jun 11, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 11, 2024
* Add sort processor documentation

Signed-off-by: Melissa Vagi <[email protected]>

* add text and examples

Signed-off-by: Melissa Vagi <[email protected]>

* Update sort.md

Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/sort.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/sort.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update sort.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/sort.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/sort.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/sort.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/sort.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 28f6642)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@vagimeli vagimeli deleted the sort-processor branch June 11, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress backport 2.14 PR: Backport label for 2.14 Content gap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants