Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates navigation header background color #5880

Merged
merged 2 commits into from Dec 16, 2023
Merged

Updates navigation header background color #5880

merged 2 commits into from Dec 16, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2023

Description

Updates the background color of the header navigation. The same change is going to be made for the 1.3 branch as well as in the project website. This change uses a solid color instead of one with transparency, because the background colors of the body elements are different in the project website and the documentation site which makes a slightly darker tint in the header in the project website than the documentation site.

This also adds a kludge to get around outdated SCSS compilers not liking the min function with mixed units which has already been pushed to 1.3.

Corrects header logo link URL.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…d outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>
@ghost ghost changed the title Updates navigation header background color; and a kludge to get aroun… Updates navigation header background color Dec 14, 2023
Signed-off-by: Aaron Stephanus <[email protected]>
@hdhalter hdhalter added the backport-to-all PR must be backported to all versions back to 1.3 label Dec 16, 2023
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdhalter hdhalter merged commit e845866 into opensearch-project:main Dec 16, 2023
4 checks passed
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
@kolchfa-aws kolchfa-aws added backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 backport 2.7 PR: Backport label for 2.7 backport 2.8 PR: Backport label for 2.8 backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11 and removed backport-to-all PR must be backported to all versions back to 1.3 labels Dec 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-5880-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e845866e8eacd8d698b0084cfad183768e7b2b16
# Push it to GitHub
git push --set-upstream origin backport/backport-5880-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport/backport-5880-to-2.8.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers

Signed-off-by: Aaron Stephanus <[email protected]>

* Corrects site header logo link url

Signed-off-by: Aaron Stephanus <[email protected]>

---------

Signed-off-by: Aaron Stephanus <[email protected]>
(cherry picked from commit e845866)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers



* Corrects site header logo link url



---------


(cherry picked from commit e845866)

Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 backport 2.7 PR: Backport label for 2.7 backport 2.8 PR: Backport label for 2.8 backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants