-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates navigation header background color #5880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]>
ghost
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
AMoo-Miki and
natebower
as code owners
December 14, 2023 20:02
ghost
changed the title
Updates navigation header background color; and a kludge to get aroun…
Updates navigation header background color
Dec 14, 2023
Signed-off-by: Aaron Stephanus <[email protected]>
hdhalter
added
the
backport-to-all
PR must be backported to all versions back to 1.3
label
Dec 16, 2023
kolchfa-aws
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]>
kolchfa-aws
added
backport 2.0
PR: Backport label for v2.0.x
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
backport 2.5
PR: Backport label for 2.5
backport 2.6
PR: Backport label for 2.6
backport 2.7
PR: Backport label for 2.7
backport 2.8
PR: Backport label for 2.8
backport 2.9
PR: Backport label for 2.9
backport 2.10
PR: Backport label for 2.10
backport 2.11
PR: Backport label for 2.11
and removed
backport-to-all
PR must be backported to all versions back to 1.3
labels
Dec 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-5880-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e845866e8eacd8d698b0084cfad183768e7b2b16
# Push it to GitHub
git push --set-upstream origin backport/backport-5880-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.8 Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers Signed-off-by: Aaron Stephanus <[email protected]> * Corrects site header logo link url Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> (cherry picked from commit e845866) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Updates navigation header background color; and a kludge to get around outdatd SCSS compilers * Corrects site header logo link url --------- (cherry picked from commit e845866) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.0
PR: Backport label for v2.0.x
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
backport 2.5
PR: Backport label for 2.5
backport 2.6
PR: Backport label for 2.6
backport 2.7
PR: Backport label for 2.7
backport 2.8
PR: Backport label for 2.8
backport 2.9
PR: Backport label for 2.9
backport 2.10
PR: Backport label for 2.10
backport 2.11
PR: Backport label for 2.11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the background color of the header navigation. The same change is going to be made for the 1.3 branch as well as in the project website. This change uses a solid color instead of one with transparency, because the background colors of the body elements are different in the project website and the documentation site which makes a slightly darker tint in the header in the project website than the documentation site.
This also adds a kludge to get around outdated SCSS compilers not liking the
min
function with mixed units which has already been pushed to 1.3.Corrects header logo link URL.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.