Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add drop processor #5767

Merged
merged 16 commits into from
Mar 7, 2024
Merged

[DOC] Add drop processor #5767

merged 16 commits into from
Mar 7, 2024

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Dec 1, 2023

Description

Adds drop processor documentation to close content gap

Issues Resolved

#proce

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli
Copy link
Contributor Author

vagimeli commented Dec 1, 2023

Hi @macohen & @msfroh, Will you review, or direct me to the appropriate reviewer, for the ingest processor documentation? We're working through content gaps and need dev reviewers to vet technical accuracy. Thank you.

META issue for reference #4647

@vagimeli vagimeli self-assigned this Dec 15, 2023
@vagimeli vagimeli added Needs SME Waiting on input from subject matter expert 3 - Tech review PR: Tech review in progress Content gap Blocked PR: Cannot move forward without assistance and removed Needs SME Waiting on input from subject matter expert labels Dec 15, 2023
@vagimeli
Copy link
Contributor Author

vagimeli commented Dec 21, 2023

@hdhalter I've requested several tech reviews via OpenSearch community Slack channel and AWS OpenSearch Slack channel. No response to date. Who is the SDM for ingest processors for OpenSearch core? The Data Prepper team told me that this isn't their lane.

@msfroh
Copy link
Contributor

msfroh commented Dec 21, 2023

I can take a look at this once I'm back home on Tuesday.

@vagimeli
Copy link
Contributor Author

I can take a look at this once I'm back home on Tuesday.

@msfroh You've been been more than helpful with tech reviewing the other three ingest processors. We're trying to load balance the content gap reviews, and I don't want you to get caught exclusively on this and the remaining 9-10 ingest processors. Please don't prioritize this while you're OOO. Let us see if we can find someone to share the load. I'll keep you updated. Thank you again for all your help and reviews :)

Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress and removed Blocked PR: Cannot move forward without assistance 3 - Tech review PR: Tech review in progress labels Jan 10, 2024
@vagimeli
Copy link
Contributor Author

@gaobinlong Please review this processor documentation at your availability. Will you provide examples relevant to OpenSearch users? Thank you for your support!

@vagimeli vagimeli changed the title [DOC] Add drop processor doc to address content gap [DOC] Add drop processor Feb 15, 2024
The following is the syntax for the `drop` processor:

```json
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
"drop": {
"if": "ctx.foo == 'bar'"
}
}

{
"user_info": "Sensitive information including credit card"
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following response shows that the no operation happened, the document with id 1 was not indexed:

{
  "_index": "testindex1",
  "_id": "1",
  "_version": -3,
  "result": "noop",
  "_shards": {
    "total": 0,
    "successful": 0,
    "failed": 0
  }
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be removed?

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Copy link
Contributor Author

@gaobinlong Thank you for the examples. I've added them to the doc. Will you approve as the tech reviewer? Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my mad, this file shouldn't be removed, I just saw this change was not related to the drop processor so I thought it shouldn't be in this PR, actually it was a small change for the date processor, so please add this file back, thanks!

Copy link
Contributor

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!

_ingest-pipelines/processors/drop.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/drop.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/drop.md Outdated Show resolved Hide resolved

Follow these steps to use the processor in a pipeline.

**Step 1: Create a pipeline.**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global: I believe that these do not take periods.

_ingest-pipelines/processors/drop.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/drop.md Outdated Show resolved Hide resolved
```
{% include copy-curl.html %}

The following response confirms that the document with ID `1` was not indexed:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with the ID 1" or "with the ID of 1"?

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with noted comments/changes.

vagimeli and others added 6 commits March 7, 2024 09:36
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added 3 - Done Issue is done/complete backport 2.12 PR: Backport label for 2.12 and removed 4 - Doc review PR: Doc review in progress labels Mar 7, 2024
@vagimeli vagimeli merged commit b38ba75 into main Mar 7, 2024
4 checks passed
@vagimeli vagimeli deleted the drop-processor branch March 7, 2024 16:45
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 7, 2024
* Add drop processor doc to address content gap

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review feedback

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review changes

Signed-off-by: Melissa Vagi <[email protected]>

* Delete _ingest-pipelines/processors/date.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Revert "Delete _ingest-pipelines/processors/date.md"

This reverts commit 73296f5.

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update drop.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit b38ba75)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Mar 7, 2024
* Add drop processor doc to address content gap



* Address tech review feedback



* Address tech review changes



* Delete _ingest-pipelines/processors/date.md





* Revert "Delete _ingest-pipelines/processors/date.md"

This reverts commit 73296f5.

* Update _ingest-pipelines/processors/drop.md




* Update _ingest-pipelines/processors/drop.md




* Update _ingest-pipelines/processors/drop.md




* Update _ingest-pipelines/processors/drop.md




* Update _ingest-pipelines/processors/drop.md




* Update drop.md





---------



(cherry picked from commit b38ba75)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nathan Bower <[email protected]>
oeyh pushed a commit to oeyh/documentation-website that referenced this pull request Mar 14, 2024
* Add drop processor doc to address content gap

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review feedback

Signed-off-by: Melissa Vagi <[email protected]>

* Address tech review changes

Signed-off-by: Melissa Vagi <[email protected]>

* Delete _ingest-pipelines/processors/date.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

* Revert "Delete _ingest-pipelines/processors/date.md"

This reverts commit 73296f5.

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _ingest-pipelines/processors/drop.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update drop.md

Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete backport 2.12 PR: Backport label for 2.12 Content gap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants