-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds info about new codecs #4571
Conversation
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one suggestion.
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
…hot-restore.md Co-authored-by: Chris Moore <[email protected]> Signed-off-by: Heather Halter <[email protected]>
@sarthakaggarwal97 -please review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdhalter Please see my comments and changes and let me know if you have any questions. Thanks!
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
@@ -330,30 +333,36 @@ POST /_snapshot/my-repository/2/_restore | |||
|
|||
Request parameters | Description | |||
:--- | :--- | |||
`indices` | The indices you want to restore. You can use `,` to create a list of indices, `*` to specify an index pattern, and `-` to exclude certain indices. Don't put spaces between items. Default is all indices. | |||
`indices` | The indexes you want to restore. You can use `,` to create a list of indexes, `*` to specify an index pattern, and `-` to exclude certain indexes. Don't put spaces between items. Default is all indexes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entire list: Should the defaults be in tic marks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks like we add tic marks to the default values.
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]>
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
…hot-restore.md Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md Signed-off-by: Heather Halter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing few OpenSearch.simple validation failing, rest LGTM! Thanks @hdhalter
@@ -209,14 +212,14 @@ You specify two pieces of information when you create a snapshot: | |||
- Name of your snapshot repository | |||
- Name for the snapshot | |||
|
|||
The following snapshot includes all indices and the cluster state: | |||
The following snapshot includes all indexes and the cluster state: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always thought its Indices but interesting to know both plurals are correct
Removed information about codecs in favor of a separate PR Signed-off-by: Heather Halter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* addedinfoaboutcodecs Signed-off-by: Heather Halter <[email protected]> * added collapsible toc Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Chris Moore <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Signed-off-by: Heather Halter <[email protected]> * Update snapshot-restore.md Removed information about codecs in favor of a separate PR Signed-off-by: Heather Halter <[email protected]> --------- Signed-off-by: Heather Halter <[email protected]> Signed-off-by: Heather Halter <[email protected]> Co-authored-by: Chris Moore <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
* addedinfoaboutcodecs Signed-off-by: Heather Halter <[email protected]> * added collapsible toc Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Chris Moore <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Signed-off-by: Heather Halter <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Signed-off-by: Heather Halter <[email protected]> * Update snapshot-restore.md Removed information about codecs in favor of a separate PR Signed-off-by: Heather Halter <[email protected]> --------- Signed-off-by: Heather Halter <[email protected]> Signed-off-by: Heather Halter <[email protected]> Co-authored-by: Chris Moore <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Description
Adds info about new codecs
Issues Resolved
Related to #3816
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.