Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds info about new codecs #4571

Merged
merged 13 commits into from
Jul 20, 2023
Merged

Adds info about new codecs #4571

merged 13 commits into from
Jul 20, 2023

Conversation

hdhalter
Copy link
Contributor

Description

Adds info about new codecs

Issues Resolved

Related to #3816

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one suggestion.

…hot-restore.md

Co-authored-by: Chris Moore <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
@hdhalter
Copy link
Contributor Author

@sarthakaggarwal97 -please review. Thanks!

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdhalter Please see my comments and changes and let me know if you have any questions. Thanks!

@@ -330,30 +333,36 @@ POST /_snapshot/my-repository/2/_restore

Request parameters | Description
:--- | :---
`indices` | The indices you want to restore. You can use `,` to create a list of indices, `*` to specify an index pattern, and `-` to exclude certain indices. Don't put spaces between items. Default is all indices.
`indices` | The indexes you want to restore. You can use `,` to create a list of indexes, `*` to specify an index pattern, and `-` to exclude certain indexes. Don't put spaces between items. Default is all indexes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entire list: Should the defaults be in tic marks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like we add tic marks to the default values.

hdhalter and others added 6 commits July 17, 2023 09:53
…hot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
…hot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
@hdhalter hdhalter self-assigned this Jul 17, 2023
@hdhalter hdhalter added the 6 - Done but waiting to merge PR: The work is done and ready to merge label Jul 17, 2023
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing few OpenSearch.simple validation failing, rest LGTM! Thanks @hdhalter

@@ -209,14 +212,14 @@ You specify two pieces of information when you create a snapshot:
- Name of your snapshot repository
- Name for the snapshot

The following snapshot includes all indices and the cluster state:
The following snapshot includes all indexes and the cluster state:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought its Indices but interesting to know both plurals are correct

Removed information about codecs in favor of a separate PR

Signed-off-by: Heather Halter <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdhalter hdhalter merged commit 3e1e8ce into main Jul 20, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* addedinfoaboutcodecs

Signed-off-by: Heather Halter <[email protected]>

* added collapsible toc

Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Chris Moore <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Signed-off-by: Heather Halter <[email protected]>

* Update snapshot-restore.md

Removed information about codecs in favor of a separate PR

Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: Chris Moore <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
* addedinfoaboutcodecs

Signed-off-by: Heather Halter <[email protected]>

* added collapsible toc

Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Chris Moore <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Signed-off-by: Heather Halter <[email protected]>

* Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md

Signed-off-by: Heather Halter <[email protected]>

* Update snapshot-restore.md

Removed information about codecs in favor of a separate PR

Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: Chris Moore <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
@hdhalter hdhalter deleted the update-snapshotdoc-for-new-codecs branch March 28, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants