Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes merger conflicts for the 2.1 branch in cookie splitting PR #3807 #3890

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Apr 27, 2023

Description

This fixes a merge conflict in the PR: Add new settings for SAML and OIDC that allow for cookie splitting #3807

Issues Resolved

Merge conflict resolved in #3807 for the 2.1 branch.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum cwillum added the backport 2.1 PR: Backport label for 2.1 label Apr 27, 2023
@cwillum cwillum self-assigned this Apr 27, 2023
@cwillum cwillum merged commit f6328ad into 2.1 Apr 27, 2023
@github-actions github-actions bot deleted the backport/backport-3807-to-2.1 branch April 27, 2023 17:22
@opensearch-trigger-bot
Copy link

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3890-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f6328add42191621ea8bac8d632f45dd7298df76
# Push it to GitHub
git push --set-upstream origin backport/backport-3890-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-3890-to-2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.1 PR: Backport label for 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant