-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline icons to formatting guide #3785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <[email protected]>
hdhalter
approved these changes
Apr 14, 2023
ariamarble
approved these changes
Apr 14, 2023
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
reviewed
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws Just a few minor changes. Thanks!
Co-authored-by: Nathan Bower <[email protected]>
kolchfa-aws
added
backport 1.3
PR: Backport label for v1.3.x
backport 2.0
PR: Backport label for v2.0.x
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
backport 2.5
PR: Backport label for 2.5
backport 2.6
PR: Backport label for 2.6
labels
Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit deae166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
kolchfa-aws
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
kolchfa-aws
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
kolchfa-aws
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
kolchfa-aws
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
kolchfa-aws
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
kolchfa-aws
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Add inline icons to formatting guide * Added space for formatting * Apply suggestions from code review --------- (cherry picked from commit deae166) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
May 4, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
* Add inline icons to formatting guide Signed-off-by: Fanit Kolchina <[email protected]> * Added space for formatting Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.3
PR: Backport label for v1.3.x
backport 2.0
PR: Backport label for v2.0.x
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
backport 2.5
PR: Backport label for 2.5
backport 2.6
PR: Backport label for 2.6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add inline icons to formatting guide and an example
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.