Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic templates from a mapping example (#3698) #3717

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

kolchfa-aws
Copy link
Collaborator

  • Remove dynamic templates from a mapping example

Signed-off-by: Fanit Kolchina [email protected]

  • Doc review comments

Signed-off-by: Fanit Kolchina [email protected]

  • Added an illustration of ignored parameter

Signed-off-by: Fanit Kolchina [email protected]

  • Implemented doc review comments

Signed-off-by: Fanit Kolchina [email protected]


Signed-off-by: Fanit Kolchina [email protected]
(cherry picked from commit 7257b21)

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Remove dynamic templates from a mapping example

Signed-off-by: Fanit Kolchina <[email protected]>

* Doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Added an illustration of ignored parameter

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 7257b21)
@kolchfa-aws kolchfa-aws requested a review from a team as a code owner April 8, 2023 01:00
@kolchfa-aws kolchfa-aws merged commit d2bf7d4 into 2.6 Apr 8, 2023
@github-actions github-actions bot deleted the backport/backport-3698-to-2.6 branch April 8, 2023 01:01
@kolchfa-aws kolchfa-aws added the backport 2.5 PR: Backport label for 2.5 label Apr 8, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 8, 2023
* Remove dynamic templates from a mapping example

Signed-off-by: Fanit Kolchina <[email protected]>

* Doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Added an illustration of ignored parameter

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kolchfa-aws kolchfa-aws added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 labels Apr 8, 2023
kolchfa-aws pushed a commit that referenced this pull request Apr 8, 2023
* Remove dynamic templates from a mapping example



* Doc review comments



* Added an illustration of ignored parameter



* Implemented doc review comments



---------


(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 8, 2023
* Remove dynamic templates from a mapping example

Signed-off-by: Fanit Kolchina <[email protected]>

* Doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Added an illustration of ignored parameter

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 8, 2023
* Remove dynamic templates from a mapping example

Signed-off-by: Fanit Kolchina <[email protected]>

* Doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Added an illustration of ignored parameter

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-3717-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d2bf7d4f234724c26ba7d248aa2b5fa59042ab0c
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-3717-to-2.0.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-3717-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d2bf7d4f234724c26ba7d248aa2b5fa59042ab0c
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-3717-to-2.2.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 8, 2023
* Remove dynamic templates from a mapping example

Signed-off-by: Fanit Kolchina <[email protected]>

* Doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Added an illustration of ignored parameter

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3717-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d2bf7d4f234724c26ba7d248aa2b5fa59042ab0c
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-3717-to-2.1.

kolchfa-aws pushed a commit that referenced this pull request Apr 8, 2023
* Remove dynamic templates from a mapping example



* Doc review comments



* Added an illustration of ignored parameter



* Implemented doc review comments



---------


(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Apr 8, 2023
* Remove dynamic templates from a mapping example



* Doc review comments



* Added an illustration of ignored parameter



* Implemented doc review comments



---------


(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit that referenced this pull request Apr 10, 2023
* Remove dynamic templates from a mapping example



* Doc review comments



* Added an illustration of ignored parameter



* Implemented doc review comments



---------


(cherry picked from commit 7257b21)
(cherry picked from commit d2bf7d4)

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant