-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dynamic templates from a mapping example (#3698) #3717
Conversation
* Remove dynamic templates from a mapping example Signed-off-by: Fanit Kolchina <[email protected]> * Doc review comments Signed-off-by: Fanit Kolchina <[email protected]> * Added an illustration of ignored parameter Signed-off-by: Fanit Kolchina <[email protected]> * Implemented doc review comments Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 7257b21)
* Remove dynamic templates from a mapping example Signed-off-by: Fanit Kolchina <[email protected]> * Doc review comments Signed-off-by: Fanit Kolchina <[email protected]> * Added an illustration of ignored parameter Signed-off-by: Fanit Kolchina <[email protected]> * Implemented doc review comments Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Remove dynamic templates from a mapping example * Doc review comments * Added an illustration of ignored parameter * Implemented doc review comments --------- (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Remove dynamic templates from a mapping example Signed-off-by: Fanit Kolchina <[email protected]> * Doc review comments Signed-off-by: Fanit Kolchina <[email protected]> * Added an illustration of ignored parameter Signed-off-by: Fanit Kolchina <[email protected]> * Implemented doc review comments Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Remove dynamic templates from a mapping example Signed-off-by: Fanit Kolchina <[email protected]> * Doc review comments Signed-off-by: Fanit Kolchina <[email protected]> * Added an illustration of ignored parameter Signed-off-by: Fanit Kolchina <[email protected]> * Implemented doc review comments Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-3717-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d2bf7d4f234724c26ba7d248aa2b5fa59042ab0c
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-3717-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d2bf7d4f234724c26ba7d248aa2b5fa59042ab0c
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.2 Then, create a pull request where the |
* Remove dynamic templates from a mapping example Signed-off-by: Fanit Kolchina <[email protected]> * Doc review comments Signed-off-by: Fanit Kolchina <[email protected]> * Added an illustration of ignored parameter Signed-off-by: Fanit Kolchina <[email protected]> * Implemented doc review comments Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3717-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d2bf7d4f234724c26ba7d248aa2b5fa59042ab0c
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1 Then, create a pull request where the |
* Remove dynamic templates from a mapping example * Doc review comments * Added an illustration of ignored parameter * Implemented doc review comments --------- (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Remove dynamic templates from a mapping example * Doc review comments * Added an illustration of ignored parameter * Implemented doc review comments --------- (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Remove dynamic templates from a mapping example * Doc review comments * Added an illustration of ignored parameter * Implemented doc review comments --------- (cherry picked from commit 7257b21) (cherry picked from commit d2bf7d4) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Fanit Kolchina [email protected]
Signed-off-by: Fanit Kolchina [email protected]
Signed-off-by: Fanit Kolchina [email protected]
Signed-off-by: Fanit Kolchina [email protected]
Signed-off-by: Fanit Kolchina [email protected]
(cherry picked from commit 7257b21)
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.