Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved index_template permission to cluster section #2964

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Moved index_template permission to cluster section #2964

merged 2 commits into from
Feb 20, 2023

Conversation

FrcMoya
Copy link
Contributor

@FrcMoya FrcMoya commented Feb 20, 2023

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Description

This PR try to solve a common mistake when generating roles that allows index_template permissions.

Issues Resolved

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@FrcMoya
Moved index_template permission to cluster section
7045f57 
Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>
@FrcMoya FrcMoya requested a review from a team as a code owner February 20, 2023 13:40
@Naarcha-AWS Naarcha-AWS added the 4 - Doc review PR: Doc review in progress label Feb 20, 2023
kolchfa-aws
kolchfa-aws approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggested rewording per style guide. Thank you!

@Naarcha-AWS Naarcha-AWS added backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 labels Feb 20, 2023
@Naarcha-AWS Naarcha-AWS merged commit d22a534 into opensearch-project:main Feb 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
@FrcMoya @github-actions
Moved index_template permission to cluster section (#2964)
64b6672 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)
This was referenced Feb 20, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
@FrcMoya @github-actions
Moved index_template permission to cluster section (#2964)
3812475 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
@FrcMoya @github-actions
Moved index_template permission to cluster section (#2964)
b70e0e5 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)
This was referenced Feb 20, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
@FrcMoya @github-actions
Moved index_template permission to cluster section (#2964)
050f882 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 20, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
@FrcMoya @github-actions
Moved index_template permission to cluster section (#2964)
24ec15a 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 20, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
@FrcMoya @github-actions
Moved index_template permission to cluster section (#2964)
9130a5a 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)
Naarcha-AWS pushed a commit that referenced this pull request Feb 20, 2023
@opensearch-trigger-bot @FrcMoya
Moved index_template permission to cluster section (#2964) (#2979)
463f6b9 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)

Co-authored-by: Fran Moya <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Feb 20, 2023
@opensearch-trigger-bot @FrcMoya
Moved index_template permission to cluster section (#2964) (#2978)
3f72285 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)

Co-authored-by: Fran Moya <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Feb 20, 2023
@opensearch-trigger-bot @FrcMoya
Moved index_template permission to cluster section (#2964) (#2977)
e5dcaa1 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)

Co-authored-by: Fran Moya <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Feb 20, 2023
@opensearch-trigger-bot @FrcMoya
Moved index_template permission to cluster section (#2964) (#2976)
bf2c0cd 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)

Co-authored-by: Fran Moya <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Feb 20, 2023
@opensearch-trigger-bot @FrcMoya
Moved index_template permission to cluster section (#2964) (#2975)
6e7ff93 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)

Co-authored-by: Fran Moya <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Feb 20, 2023
@opensearch-trigger-bot @FrcMoya
Moved index_template permission to cluster section (#2964) (#2974)
aa39391 
* Moved index_template permission to cluster section

Moved index_template permissions from index section to cluster section to avoid confusion when generating roles

Signed-off-by: Fran Moya <[email protected]>

* Update _security/access-control/permissions.md

Co-authored-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Fran Moya <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit d22a534)

Co-authored-by: Fran Moya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@Naarcha-AWS Naarcha-AWS Naarcha-AWS approved these changes

Assignees
No one assigned
Labels
4 - Doc review PR: Doc review in progress backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Index Template APIs need to be specified under cluster permissions rather than index permissions
3 participants
@FrcMoya @Naarcha-AWS @kolchfa-aws