Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lambda example in reporting cli doc #2754

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

rupal-bq
Copy link
Member

@rupal-bq rupal-bq commented Feb 9, 2023

Signed-off-by: Rupal Mahajan [email protected]

Description

  • Updated example to use npm registry instead of tar file so users can get latest version.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rupal-bq rupal-bq requested a review from a team as a code owner February 9, 2023 19:12
@alicejw1 alicejw1 added the backport 2.5 PR: Backport label for 2.5 label Feb 9, 2023
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naarcha-AWS Naarcha-AWS added the backport 2.6 PR: Backport label for 2.6 label Mar 6, 2023
@Naarcha-AWS Naarcha-AWS added the backport 1.3 PR: Backport label for v1.3.x label Mar 21, 2023
@carolxob carolxob self-requested a review March 21, 2023 16:52
@Naarcha-AWS Naarcha-AWS merged commit a89eeb0 into opensearch-project:main Mar 21, 2023
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2754-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a89eeb0a9c296bf6d66dd61dd3fb9190fbb64ff8
# Push it to GitHub
git push --set-upstream origin backport/backport-2754-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2754-to-1.3.

@opensearch-trigger-bot
Copy link

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.5 2.5
# Navigate to the new working tree
pushd ../.worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-2754-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a89eeb0a9c296bf6d66dd61dd3fb9190fbb64ff8
# Push it to GitHub
git push --set-upstream origin backport/backport-2754-to-2.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-2754-to-2.5.

@opensearch-trigger-bot
Copy link

The backport to 2.6 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.6 2.6
# Navigate to the new working tree
pushd ../.worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-2754-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a89eeb0a9c296bf6d66dd61dd3fb9190fbb64ff8
# Push it to GitHub
git push --set-upstream origin backport/backport-2754-to-2.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.6

Then, create a pull request where the base branch is 2.6 and the compare/head branch is backport/backport-2754-to-2.6.

Naarcha-AWS pushed a commit that referenced this pull request Mar 21, 2023
Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit a89eeb0)
Naarcha-AWS added a commit that referenced this pull request Mar 21, 2023
Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit a89eeb0)

Co-authored-by: Rupal Mahajan <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Mar 21, 2023
Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit a89eeb0)
Naarcha-AWS added a commit that referenced this pull request Mar 21, 2023
Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit a89eeb0)

Co-authored-by: Rupal Mahajan <[email protected]>
vagimeli pushed a commit that referenced this pull request May 4, 2023
vagimeli added a commit that referenced this pull request May 4, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants