Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster awareness and decommission docs #2438

Merged
merged 30 commits into from
Jan 23, 2023
Merged

Add cluster awareness and decommission docs #2438

merged 30 commits into from
Jan 23, 2023

Conversation

Naarcha-AWS
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS commented Jan 19, 2023 •
edited
Loading

Signed-off-by: Naarcha-AWS [email protected]

Description

Fixes #1811 and #1812

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS Naarcha-AWS added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 19, 2023
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner January 19, 2023 17:44
@Naarcha-AWS Naarcha-AWS added the 3 - Tech review PR: Tech review in progress label Jan 19, 2023
@Naarcha-AWS Naarcha-AWS self-assigned this Jan 19, 2023
@Naarcha-AWS
Edit technical feedback
2009556 
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS added the release-notes PR: Include this PR in the automated release notes label Jan 19, 2023
carolxob
carolxob approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of very minor changes.

alicejw1
alicejw1 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

_api-reference/cluster-awareness.md Outdated

## Example: Weighted round robin search

The following sample request creates a round robin shard allocation for search traffic, using an undefined ratio.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're using colons to precede code blocks again. "The following example. ..:"

_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels Jan 23, 2023
@Naarcha-AWS
Add Caroline's feedback
d17cf00 
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS
Add one more tweak
fcefe54 
Signed-off-by: Naarcha-AWS <[email protected]>
hdhalter
hdhalter reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nit-picky things.

_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_api-reference/cluster-decommission.md Outdated Show resolved Hide resolved
_api-reference/cluster-decommission.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
natebower
natebower reviewed Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!

_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_api-reference/cluster-awareness.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Jan 23, 2023
Naarcha-AWS and others added 19 commits January 23, 2023 14:27
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
ab9c864 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
78b17a3 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
dfbd089 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _ml-commons-plugin/cluster-settings.md
8834026 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
f1647f6 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
9c528ec 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
ddce7a0 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
164ab0c 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
d571148 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _ml-commons-plugin/cluster-settings.md
f8f6a82 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
69859c7 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
17d7c97 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-decommission.md
0ed2074 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-awareness.md
88183c8 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS @natebower
Update _api-reference/cluster-decommission.md
306d242 
Co-authored-by: Nate Bower <[email protected]>
@Naarcha-AWS
Add editoiral feedback
b8eb313 
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS
Fix typos
be4b3c4 
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS
Final editorial note
94c4a10 
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS
Fix merge conflicts
7254b92 
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS merged commit 1589201 into main Jan 23, 2023
@Naarcha-AWS Naarcha-AWS deleted the weighted-zonal branch January 23, 2023 23:13
vagimeli pushed a commit that referenced this pull request Jan 25, 2023
@Naarcha-AWS @Bukhtawar
@alicejw1 @hdhalter @natebower @vagimeli
Add cluster awareness and decommission docs (#2438)
891be1f 
* Add cluster awareness and decommission docs

Signed-off-by: Naarcha-AWS <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Bukhtawar Khan <[email protected]>

* Edit technical feedback

Signed-off-by: Naarcha-AWS <[email protected]>

* Add new cluster awareness examples

Signed-off-by: Naarcha-AWS <[email protected]>

* Add technical feedback

Signed-off-by: Naarcha-AWS <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Alice Williams <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Alice Williams <[email protected]>

* Add Caroline's feedback

Signed-off-by: Naarcha-AWS <[email protected]>

* Add one more tweak

Signed-off-by: Naarcha-AWS <[email protected]>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: Heather Halter <[email protected]>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: Heather Halter <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-decommission.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-awareness.md

Co-authored-by: Nate Bower <[email protected]>

* Update _api-reference/cluster-decommission.md

Co-authored-by: Nate Bower <[email protected]>

* Add editoiral feedback

Signed-off-by: Naarcha-AWS <[email protected]>

* Fix typos

Signed-off-by: Naarcha-AWS <[email protected]>

* Final editorial note

Signed-off-by: Naarcha-AWS <[email protected]>

Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
Co-authored-by: Alice Williams <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Nate Bower <[email protected]>
vagimeli added a commit that referenced this pull request Jan 26, 2023
@vagimeli
Revert "Add cluster awareness and decommission docs (#2438)"
1ef8ff9 
This reverts commit 891be1f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdhalter hdhalter hdhalter left review comments

@natebower natebower natebower left review comments

@Bukhtawar Bukhtawar Bukhtawar left review comments

@carolxob carolxob carolxob approved these changes

@alicejw1 alicejw1 alicejw1 approved these changes

Assignees

@Naarcha-AWS Naarcha-AWS

Labels
release-notes PR: Include this PR in the automated release notes v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Weighted Round Robin shard routing
6 participants
@Naarcha-AWS @Bukhtawar @alicejw1 @natebower @hdhalter @carolxob