Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes allow_partial_pit_creation #2411

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fixes allow_partial_pit_creation #2411

merged 1 commit into from
Jan 17, 2023

Conversation

kolchfa-aws
Copy link
Collaborator

Fixes allow_partial_pit_creation

Checklist

  • [x ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws
Fixes allow_partial_pit_creation
23f3a8b 
Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws self-assigned this Jan 17, 2023
@kolchfa-aws kolchfa-aws requested a review from a team as a code owner January 17, 2023 16:39
@kolchfa-aws kolchfa-aws added the backport 2.4 PR: Backport label for 2.4 label Jan 17, 2023
hdhalter
hdhalter approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please make sure going forward to add an associated issue or note about where the input came from. Primarily so we can have a paper trail of who/how/why we are making the change. Thanks!

@kolchfa-aws kolchfa-aws merged commit 32767eb into main Jan 17, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 17, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 17, 2023
@kolchfa-aws @github-actions
Fixes allow_partial_pit_creation (#2411)
bf3a086 
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 32767eb)
kolchfa-aws added a commit that referenced this pull request Jan 17, 2023
@opensearch-trigger-bot @kolchfa-aws
Fixes allow_partial_pit_creation (#2411) (#2413)
5b09fe6 
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 32767eb)

Co-authored-by: kolchfa-aws <[email protected]>
vagimeli pushed a commit that referenced this pull request Jan 25, 2023
@kolchfa-aws @vagimeli
Fixes allow_partial_pit_creation (#2411)
41217aa 
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
vagimeli added a commit that referenced this pull request Jan 26, 2023
@vagimeli
Revert "Fixes allow_partial_pit_creation (#2411)"
22e1f90 
This reverts commit 41217aa.
@Naarcha-AWS Naarcha-AWS deleted the pit-update branch March 28, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffHuss JeffHuss JeffHuss approved these changes

@hdhalter hdhalter hdhalter approved these changes

@Naarcha-AWS Naarcha-AWS Naarcha-AWS approved these changes

Assignees

@kolchfa-aws kolchfa-aws

Labels
backport 2.4 PR: Backport label for 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kolchfa-aws @Naarcha-AWS @hdhalter @JeffHuss