-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Peer Forwarder to doc website repo #2373
Conversation
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
…o simplify wording. Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Co-authored-by: Aria Marble <[email protected]>
Co-authored-by: Aria Marble <[email protected]>
Co-authored-by: Aria Marble <[email protected]>
Co-authored-by: Aria Marble <[email protected]>
Co-authored-by: Aria Marble <[email protected]>
Co-authored-by: Aria Marble <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
…icable. Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor change.
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
* Add Peer forwarder to doc site repo. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Minor updates to header section. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading adjustements. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading updates. Additional of Optional section to simplify wording. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading adjustments. Signed-off-by: carolxob <[email protected]> * Changed capitalization in title. Signed-off-by: carolxob <[email protected]> * Minor changes from doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Trying to commit file. Signed-off-by: carolxob <[email protected]> * Trying to push file. Signed-off-by: carolxob <[email protected]> * Trying to push file again. Signed-off-by: carolxob <[email protected]> * Trying to push file one more time after rebasing. Signed-off-by: carolxob <[email protected]> * Minor change. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Converted optional configuration section to table. Signed-off-by: carolxob <[email protected]> * Minor adjustmenets. Signed-off-by: carolxob <[email protected]> * Minor adjustments again. Signed-off-by: carolxob <[email protected]> * Updates from doc review feedback. Signed-off-by: carolxob <[email protected]> * Made changes based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Made minor heading adjustements. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Made updates based on editorial feedback. Signed-off-by: carolxob <[email protected]> * Made extensive changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> * Incorporated minor editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Incorporated more editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Committed existing Peer Forwarder file to new PR to simplify feedback. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Updates specifically to table formatting. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Made minor edit to the end of the Configuration table. Signed-off-by: carolxob <[email protected]> * Minor edits from doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor updates from doc review. Signed-off-by: carolxob <[email protected]> * Incorporated more editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor update to line 112. Signed-off-by: carolxob <[email protected]> * Made minor edits to references to S3. Changed to Amazon S3 where applicable. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor updates to text. Signed-off-by: carolxob <[email protected]> * Made updates based on SME and doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor change to one word. Signed-off-by: carolxob <[email protected]> * Removed a comma. Signed-off-by: carolxob <[email protected]> --------- Signed-off-by: carolxob <[email protected]> Co-authored-by: Aria Marble <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-2373-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-2373-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-2373-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-2373-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1 Then, create a pull request where the |
* Add Peer forwarder to doc site repo. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Minor updates to header section. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading adjustements. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading updates. Additional of Optional section to simplify wording. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading adjustments. Signed-off-by: carolxob <[email protected]> * Changed capitalization in title. Signed-off-by: carolxob <[email protected]> * Minor changes from doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Trying to commit file. Signed-off-by: carolxob <[email protected]> * Trying to push file. Signed-off-by: carolxob <[email protected]> * Trying to push file again. Signed-off-by: carolxob <[email protected]> * Trying to push file one more time after rebasing. Signed-off-by: carolxob <[email protected]> * Minor change. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Converted optional configuration section to table. Signed-off-by: carolxob <[email protected]> * Minor adjustmenets. Signed-off-by: carolxob <[email protected]> * Minor adjustments again. Signed-off-by: carolxob <[email protected]> * Updates from doc review feedback. Signed-off-by: carolxob <[email protected]> * Made changes based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Made minor heading adjustements. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Made updates based on editorial feedback. Signed-off-by: carolxob <[email protected]> * Made extensive changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> * Incorporated minor editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Incorporated more editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Committed existing Peer Forwarder file to new PR to simplify feedback. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Updates specifically to table formatting. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Made minor edit to the end of the Configuration table. Signed-off-by: carolxob <[email protected]> * Minor edits from doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor updates from doc review. Signed-off-by: carolxob <[email protected]> * Incorporated more editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor update to line 112. Signed-off-by: carolxob <[email protected]> * Made minor edits to references to S3. Changed to Amazon S3 where applicable. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor updates to text. Signed-off-by: carolxob <[email protected]> * Made updates based on SME and doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor change to one word. Signed-off-by: carolxob <[email protected]> * Removed a comma. Signed-off-by: carolxob <[email protected]> --------- Signed-off-by: carolxob <[email protected]> Co-authored-by: Aria Marble <[email protected]> (cherry picked from commit 86385d4)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-2373-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
* Add Peer forwarder to doc site repo. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Minor updates to header section. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading adjustements. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading updates. Additional of Optional section to simplify wording. Signed-off-by: carolxob <[email protected]> * Minor copyedits and heading adjustments. Signed-off-by: carolxob <[email protected]> * Changed capitalization in title. Signed-off-by: carolxob <[email protected]> * Minor changes from doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <[email protected]> * Trying to commit file. Signed-off-by: carolxob <[email protected]> * Trying to push file. Signed-off-by: carolxob <[email protected]> * Trying to push file again. Signed-off-by: carolxob <[email protected]> * Trying to push file one more time after rebasing. Signed-off-by: carolxob <[email protected]> * Minor change. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Converted optional configuration section to table. Signed-off-by: carolxob <[email protected]> * Minor adjustmenets. Signed-off-by: carolxob <[email protected]> * Minor adjustments again. Signed-off-by: carolxob <[email protected]> * Updates from doc review feedback. Signed-off-by: carolxob <[email protected]> * Made changes based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Made minor heading adjustements. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Made updates based on editorial feedback. Signed-off-by: carolxob <[email protected]> * Made extensive changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> * Incorporated minor editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Incorporated more editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Committed existing Peer Forwarder file to new PR to simplify feedback. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Updates specifically to table formatting. Signed-off-by: carolxob <[email protected]> * Minor updates. Signed-off-by: carolxob <[email protected]> * Made minor edit to the end of the Configuration table. Signed-off-by: carolxob <[email protected]> * Minor edits from doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor updates from doc review. Signed-off-by: carolxob <[email protected]> * Incorporated more editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor update to line 112. Signed-off-by: carolxob <[email protected]> * Made minor edits to references to S3. Changed to Amazon S3 where applicable. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor updates to text. Signed-off-by: carolxob <[email protected]> * Made updates based on SME and doc review feedback. Signed-off-by: carolxob <[email protected]> * Minor change to one word. Signed-off-by: carolxob <[email protected]> * Removed a comma. Signed-off-by: carolxob <[email protected]> --------- Signed-off-by: carolxob <[email protected]> Co-authored-by: Aria Marble <[email protected]> (cherry picked from commit 86385d4) Co-authored-by: Caroline <[email protected]>
Description
This PR takes feedback provided in PR #1936 and makes it easier to provide additional feedback.
Issues Resolved
Addresses feedback in #1936
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.