Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SAML troubleshooting page to _opendistro route to match existing route #2160

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Dec 8, 2022

Signed-off-by: Craig Perkins [email protected]

Description

The SAML configuration page was previously changed in #877 to replace /_plugins/_security with /_opendistro/_security for SAML related routes. This PR applies the same change to the troubleshooting page for SAML. A user pointed out the discrepancy here: opensearch-project/security-dashboards-plugin#836 (comment)

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team as a code owner December 8, 2022 22:16
@cwperks
Copy link
Member Author

cwperks commented Dec 8, 2022

@cwillum Small PR to update the SAML troubleshooting page.

@cwillum cwillum added the 4 - Doc review PR: Doc review in progress label Dec 8, 2022
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks LGTM. Thanks. Oh, and I'm backporting this to v2.2. since that was where the original issue was.

@cwillum cwillum self-assigned this Dec 8, 2022
@cwillum cwillum added security backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 labels Dec 8, 2022
@cwillum cwillum merged commit 0dc659c into opensearch-project:main Dec 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 9, 2022
…ng route (#2160)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 0dc659c)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 9, 2022
…ng route (#2160)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 0dc659c)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 9, 2022
…ng route (#2160)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 0dc659c)
cwillum pushed a commit that referenced this pull request Dec 9, 2022
…ng route (#2160) (#2163)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 0dc659c)

Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Dec 9, 2022
…ng route (#2160) (#2162)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 0dc659c)

Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Dec 9, 2022
…ng route (#2160) (#2161)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 0dc659c)

Co-authored-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants