-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert SAML troubleshooting page to _opendistro route to match existing route #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng route Signed-off-by: Craig Perkins <[email protected]>
@cwillum Small PR to update the SAML troubleshooting page. |
cwillum
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwperks LGTM. Thanks. Oh, and I'm backporting this to v2.2. since that was where the original issue was.
cwillum
added
security
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
labels
Dec 8, 2022
hdhalter
approved these changes
Dec 8, 2022
ariamarble
approved these changes
Dec 8, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
…ng route (#2160) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 0dc659c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
…ng route (#2160) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 0dc659c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
…ng route (#2160) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 0dc659c)
cwillum
pushed a commit
that referenced
this pull request
Dec 9, 2022
…ng route (#2160) (#2163) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 0dc659c) Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Dec 9, 2022
…ng route (#2160) (#2162) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 0dc659c) Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Dec 9, 2022
…ng route (#2160) (#2161) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 0dc659c) Co-authored-by: Craig Perkins <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - Doc review
PR: Doc review in progress
backport 2.2
PR: Backport label for 2.2
backport 2.3
PR: Backport label for 2.3
backport 2.4
PR: Backport label for 2.4
security
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins [email protected]
Description
The SAML configuration page was previously changed in #877 to replace
/_plugins/_security
with/_opendistro/_security
for SAML related routes. This PR applies the same change to the troubleshooting page for SAML. A user pointed out the discrepancy here: opensearch-project/security-dashboards-plugin#836 (comment)Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.