Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monitor ctx variables doc #1900

Closed

Conversation

partlov
Copy link

@partlov partlov commented Nov 15, 2022

Signed-off-by: Petar Partlov [email protected]

Description

Update documentation of ctx variables to be consistent with code.
This PR must be merged after opensearch-project/common-utilsGH-318

Issues Resolved

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

- Issue opensearch-project/alerting#200
- Make documentation consistent with code

Signed-off-by: Petar Partlov <[email protected]>
@Naarcha-AWS
Copy link
Collaborator

@partlov: Which version of OpenSearch do these changes apply to?

@partlov
Copy link
Author

partlov commented Nov 17, 2022

@partlov: Which version of OpenSearch do these changes apply to?

As mentioned in description this will go with PR opensearch-project/common-utilsGH-318. I'm not aware in what version this will go, probably responsible person for merging this PR will have more info.

@Naarcha-AWS Naarcha-AWS added the Blocked PR: Cannot move forward without assistance label Nov 23, 2022
@AWSHurneyt
Copy link
Contributor

@Naarcha-AWS Sorry for the delayed response. We'd like to have the documentation updated for the 2.5 release.

@ariamarble
Copy link
Contributor

@Naarcha-AWS can you review this?

@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 and removed Blocked PR: Cannot move forward without assistance labels Mar 9, 2023
@Naarcha-AWS
Copy link
Collaborator

This is blocked until opensearch-project/common-utils#318 is merged in. With that in mind, I'm going to close this for now. We can reopen if the PR in common-utils is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants