Added Sigv4 Section to JavaScript Client #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Theo Truong <[email protected]>
kolchfa-aws
reviewed
Nov 2, 2022
| @@ -141,6 +141,68 @@ async function search() { | |||
| search().catch(console.log); | |||
| ``` | |||
|
|
|||
| ## Authenticate with Amazon OpenSearch Service - AWS Sigv4 | |||
There was a problem hiding this comment.
Could we add a simple sentence to separate the headings? Suggest:
Use the following code to authenticate with Amazon OpenSearch Service.
kolchfa-aws
reviewed
Nov 2, 2022
| ## Authenticate with Amazon OpenSearch Service - AWS Sigv4 | ||
|
|
||
| ### Using AWS V2 SDK | ||
|
|
There was a problem hiding this comment.
Same as above. Suggest:
Use the following code to authenticate with AWS V2 SDK.
kolchfa-aws
reviewed
Nov 2, 2022
_clients/javascript/index.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| ### Using AWS V3 SDK |
There was a problem hiding this comment.
Same as above. Suggest:
Use the following code to authenticate with AWS V3 SDK.
kolchfa-aws
approved these changes
Nov 2, 2022
Signed-off-by: Theo Truong <[email protected]>
Naarcha-AWS
approved these changes
Nov 2, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Added Sigv4 Section to JavaScript Client Signed-off-by: Theo Truong <[email protected]> * Adjusted according to style code/headers guide Signed-off-by: Theo Truong <[email protected]> Signed-off-by: Theo Truong <[email protected]> (cherry picked from commit bdbf110)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-1796-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bdbf11074054e124a4af3ff2246db4c8336bb3ae
# Push it to GitHub
git push --set-upstream origin backport/backport-1796-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3Then, create a pull request where the |
Naarcha-AWS
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Added Sigv4 Section to JavaScript Client Signed-off-by: Theo Truong <[email protected]> * Adjusted according to style code/headers guide Signed-off-by: Theo Truong <[email protected]> Signed-off-by: Theo Truong <[email protected]> (cherry picked from commit bdbf110) Co-authored-by: Theo Nam Truong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Theo Truong [email protected]
For more information on following Developer Certificate of Origin and signing off your commits, please check here.